Remove the package exclusions #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It's all a little confusing but downstream consumers of Flipper that don't use CMake themselves otherwise don't have access to these libraries and will have them missing from their builds. I'll create an 0.2.0 release for this so 0.1.0 consumers don't end up with multiple binaries. Test Plan: Tested locally with Flipper and a stand-alone example and it seems to work.
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Mar 4, 2021
Summary: It's all a little confusing but downstream consumers of Flipper that don't use CMake themselves otherwise don't have access to these libraries and will have them missing from their builds. I'll create an 0.2.0 release for this so 0.1.0 consumers don't end up with multiple binaries. Pull Request resolved: facebookincubator/fbjni#51 Test Plan: Tested locally with Flipper and a stand-alone example and it seems to work. Reviewed By: mweststrate Differential Revision: D26815786 Pulled By: passy fbshipit-source-id: c70b56952acbe6e3be4ef74da2e4115651ce8e9c
facebook-github-bot
pushed a commit
to facebookarchive/profilo
that referenced
this pull request
Mar 4, 2021
Summary: It's all a little confusing but downstream consumers of Flipper that don't use CMake themselves otherwise don't have access to these libraries and will have them missing from their builds. I'll create an 0.2.0 release for this so 0.1.0 consumers don't end up with multiple binaries. Pull Request resolved: facebookincubator/fbjni#51 Test Plan: Tested locally with Flipper and a stand-alone example and it seems to work. Reviewed By: mweststrate Differential Revision: D26815786 Pulled By: passy fbshipit-source-id: c70b56952acbe6e3be4ef74da2e4115651ce8e9c
EduardoCostaom
pushed a commit
to EduardoCostaom/profilo
that referenced
this pull request
Nov 2, 2022
Summary: It's all a little confusing but downstream consumers of Flipper that don't use CMake themselves otherwise don't have access to these libraries and will have them missing from their builds. I'll create an 0.2.0 release for this so 0.1.0 consumers don't end up with multiple binaries. Pull Request resolved: facebookincubator/fbjni#51 Test Plan: Tested locally with Flipper and a stand-alone example and it seems to work. Reviewed By: mweststrate Differential Revision: D26815786 Pulled By: passy fbshipit-source-id: c70b56952acbe6e3be4ef74da2e4115651ce8e9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It's all a little confusing but downstream consumers of Flipper
that don't use CMake themselves otherwise don't have access to these
libraries and will have them missing from their builds.
I'll create an 0.2.0 release for this so 0.1.0 consumers don't
end up with multiple binaries.
Test Plan:
Tested locally with Flipper and a stand-alone example and it seems to
work.