Pass const reference for LookupOptions

Summary: As titled, no need to copy this (small) object. Reviewed By: cristianlumezanu Differential Revision: D48356872 fbshipit-source-id: 99f548ce9b2de29583cc68f01cd4eb61dc13d80f
facebook · Aug 26, 2023 · d463d82 · d463d82
1 parent 4c5add4
commit d463d82
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/folly/io/async/AsyncSocket.cpp b/folly/io/async/AsyncSocket.cpp
@@ -2876,7 +2876,7 @@ bool AsyncSocket::processZeroCopyWriteInProgress() noexcept {
 }
 
 folly::Expected<folly::TcpInfo, std::errc> AsyncSocket::getTcpInfo(
-    TcpInfo::LookupOptions options) {
+    const TcpInfo::LookupOptions& options) {
   if (NetworkSocket() == fd_) {
     return folly::makeUnexpected(std::errc::invalid_argument);
   }

diff --git a/folly/io/async/AsyncSocket.h b/folly/io/async/AsyncSocket.h
@@ -1186,7 +1186,7 @@ class AsyncSocket : public AsyncSocketTransport {
    * Get folly::TcpInfo from socket
    */
   folly::Expected<folly::TcpInfo, std::errc> getTcpInfo(
-      TcpInfo::LookupOptions options);
+      const TcpInfo::LookupOptions& options);
 
   /**
    * writeReturn is the total number of bytes written, or WRITE_ERROR on error.