Skip to content

Commit

Permalink
Remove assertion about little-endian from Base64SWAR
Browse files Browse the repository at this point in the history
Summary:
It doesn't appear to actually be needed as the tests pass on big endian platforms:
#1993 (comment)

Fixes: #1993

Reviewed By: Gownta

Differential Revision: D52974667

fbshipit-source-id: 89193ec75e58d54f05e1300b56d17775aab856d2
  • Loading branch information
Orvid authored and facebook-github-bot committed Jan 24, 2024
1 parent d3bf637 commit 6bff046
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions folly/detail/base64_detail/Base64SWAR.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,6 @@ constexpr auto kBase64SwarDecodeTable =
template <bool isURL>
std::uint32_t base64DecodeSWARMainLoop(
const char*& f, const char* l, char*& o) noexcept {
static_assert(
folly::kIsLittleEndian, "Big endian requires a redesigned table");

std::uint32_t errorAccumulator = 0;

while (l - f > 4) {
Expand Down

1 comment on commit 6bff046

@barracuda156
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Orvid Thank you!

Please sign in to comment.