Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare optional parameters according to HTML standard #98

Merged
merged 1 commit into from
Nov 21, 2014
Merged

Declare optional parameters according to HTML standard #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,10 +429,10 @@ declare class DataView extends ArrayBufferView {
declare var btoa: (rawString: string) => string;
declare var atob: (encodedString: string) => string;

declare function clearInterval(intervalId: number): void;
declare function clearTimeout(timeoutId: any): void;
declare function setTimeout(callback: any, ms: number, ...args: Array<any>): number;
declare function setInterval(callback: any, ms: number, ...args: Array<any>): number;
declare function clearInterval(intervalId?: number): void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these arguments to the clear functions should be optional?

declare function clearTimeout(timeoutId?: any): void;
declare function setTimeout(callback: any, ms?: number, ...args: Array<any>): number;
declare function setInterval(callback: any, ms?: number, ...args: Array<any>): number;

/* NodeJS */

Expand Down