-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bracket refinements #7597
Closed
Closed
Fix bracket refinements #7597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodmind
commented
Mar 28, 2019
goodmind
force-pushed
the
bracket-refinements
branch
from
March 28, 2019 16:13
5e1b7e5
to
aa92b38
Compare
goodmind
force-pushed
the
bracket-refinements
branch
from
March 28, 2019 16:16
aa92b38
to
f578b76
Compare
@nmote anyone who can review this? |
goodmind
changed the title
Fix bracket refinements
Fix bracket refinements in switch case
Apr 10, 2019
taking a look |
mvitousek
reviewed
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvitousek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@mvitousek hey what's with this PR? |
This was referenced Jul 31, 2019
goodmind
changed the title
Fix bracket refinements in switch case
Fix bracket refinements
Jul 31, 2019
ping @mvitousek |
@mvitousek merged this pull request in 902b088. |
This was referenced Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7475
Fixes #2990