Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bracket refinements #7597

Closed
wants to merge 4 commits into from
Closed

Conversation

goodmind
Copy link
Contributor

@goodmind goodmind commented Mar 28, 2019

Fixes #7475
Fixes #2990

src/typing/statement.ml Outdated Show resolved Hide resolved
@goodmind goodmind force-pushed the bracket-refinements branch from 5e1b7e5 to aa92b38 Compare March 28, 2019 16:13
@goodmind goodmind force-pushed the bracket-refinements branch from aa92b38 to f578b76 Compare March 28, 2019 16:16
@goodmind
Copy link
Contributor Author

goodmind commented Apr 8, 2019

@nmote anyone who can review this?

@goodmind
Copy link
Contributor Author

@mvitousek

@goodmind goodmind changed the title Fix bracket refinements Fix bracket refinements in switch case Apr 10, 2019
@mvitousek
Copy link
Contributor

taking a look

src/typing/statement.ml Outdated Show resolved Hide resolved
src/typing/statement.ml Outdated Show resolved Hide resolved
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvitousek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@goodmind
Copy link
Contributor Author

goodmind commented Jul 3, 2019

@mvitousek hey what's with this PR?

@goodmind goodmind added the Stalled Issues and PRs that are stalled. label Jul 27, 2019
@goodmind goodmind changed the title Fix bracket refinements in switch case Fix bracket refinements Jul 31, 2019
@goodmind
Copy link
Contributor Author

goodmind commented Aug 9, 2019

ping @mvitousek

@facebook-github-bot
Copy link
Contributor

@mvitousek merged this pull request in 902b088.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants