Warn on unsupported class members #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, flow would silently ignore these properties and instead users would see "Property not found" errors when they went to use the desired properties. I intentionally didn't include a fallthrough case, because the compiler will warn if this pattern ever becomes inexhaustive in the future. However, that's currently just a warning. Can we make it an error? Also, because of the way the AST is defined, some of these cases are actually syntax errors, like computed- and literal-key method bodies. I would be happy to also make the changes to the AST to restrict the representation to exclude impossible cases, if that seems important.
fd23321 :) |
|
@mroch is on 🔥! |
ghost
closed this
in
|
Awesome, thanks @samwgoldman! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, flow would silently ignore these properties and
instead users would see "Property not found" errors when they went to
use the desired properties.
I intentionally didn't include a fallthrough case, because the compiler
will warn if this pattern ever becomes inexhaustive in the future.
However, that's currently just a warning. Can we make it an error?
Also, because of the way the AST is defined, some of these cases are
actually syntax errors, like computed- and literal-key method bodies. I
would be happy to also make the changes to the AST to restrict the
representation to exclude impossible cases, if that seems important.
See #444