Make interface-defined modules work with CommonJS/ES6Module interop #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmo
force-pushed
the
treat_interface_defs_exports_as_cjs_exports_object
branch
from
4b842a4 to
0dbdc2a
Compare
avikchaudhuri
added a commit
that referenced
this pull request
Apr 22, 2015
…js_exports_object Make interface-defined modules work with CommonJS/ES6Module interop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a normal CommonJS module, when the exports object is assigned we mark it as a CommonJS default export. This lets the flow system understand that it needs to be mapped properly to an ES6 ModuleNamespace object when imported from an ES6 module.
Declared modules, however, weren't treating their exports in this way as well. This fixes the issue by marking declared module exports as CJSDefault.
More tangibly, this PR fixes this issue: #400