-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support flow-typed directories in yarn workspaces #5183
Comments
any updates on this ? |
+1 |
flow-mono-cli is a good option, but an official support would be better ! Here is small article I wrote on the topic : https://medium.com/inato/how-to-use-flow-in-a-mono-repo-8947d43d50fb 😉 |
Does it work to specify each |
After moving trezor-link to this monorepo (newly named as @trezor/transport) the flow type-checking broke because flow is not compatible with yarn workspaces we use here. facebook/flow#5183 In particular, flow fails to resolve packages hoisted to the root node_modules directory. Use yarn's nohoist option to prevent hoisting of all transport's dependencies. This might be more aggressive than needed - some packages probably can be hoisted without breaking flow. Leave that for a later optimization as the transport package is awaiting a big refactoring soon.
After moving trezor-link to this monorepo (newly named as @trezor/transport) the flow type-checking broke because flow is not compatible with yarn workspaces we use here. facebook/flow#5183 In particular, flow fails to resolve packages hoisted to the root node_modules directory. Use yarn's nohoist option to prevent hoisting of all transport's dependencies. This might be more aggressive than needed - some packages probably can be hoisted without breaking flow. Leave that for a later optimization as the transport package is awaiting a big refactoring soon.
After moving trezor-link to this monorepo (newly named as @trezor/transport) the flow type-checking broke because flow is not compatible with yarn workspaces we use here. facebook/flow#5183 In particular, flow fails to resolve packages hoisted to the root node_modules directory. Use yarn's nohoist option to prevent hoisting of all transport's dependencies. This might be more aggressive than needed - some packages probably can be hoisted without breaking flow. Leave that for a later optimization as the transport package is awaiting a big refactoring soon.
This is related to an issue in flow-typed: flow-typed/flow-typed#1391
For the first approach (one flow in the root) it would be great if you could search for typings (flow-typed directory) in the specific workspace directory and then in the root.
The text was updated successfully, but these errors were encountered: