janga: config: added janga SMB & COME card pvt sensor config #302
+1,610
−446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongedward
changed the title
zhongedward
changed the title
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mikechoifb
requested changes
Dec 18, 2024
There was a problem hiding this comment.
@zhongedward , this PR breaks Meta's build. Here is the error message we use :
E1209 22:55:14.066961 3917863 ConfigValidator.cpp:140] PmUnitSensors SlotPath /SMB_FRU_SLOT@0 doesn't match with SlotPath / of /run/devmap/sensors/SMB_U68_TMP422
Slot math seems to mismatch. Can you review the PR again?
|
@zhongedward has updated the pull request. You must reimport the pull request before landing. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for janga SMB & COME card pvt sensor config.
Motivation
1.According to the factory they have added SMB card '3 5 20' about productionstate, productversion,productsubversion.
COME card '4 1 1' about productionstate, productversion,productsubversion.
2.So i have added the following configs.
3.Note: I still put
SMB_U68_TMP422
SMB_U150_TMP422
SMB_U351_TMP422
SMB_U352_TMP422
SMB_U152_TMP422
them in SMB_FRU_SLOT because they can be recognized in SMB eeprom can not Recognized in JANGA eeprom.I have manually change the SMB eeprom to '3 5 20' it tested ok, if you put them in JANGA slot it tested fail because they belongs to SMB board.
In the hardware table, they belongs to SMB board
https://docs.google.com/spreadsheets/d/1r0Vbv1cx3KelYLEM4vl0VNyIeEpFwurG5JJZ6BckMCI/edit?gid=1519693354#gid=1519693354
Test Plan
1.The correctness of the format has been verified on this website https://jsonlint.com/
2.Used jq cmd to pretty the format.
3.Test log as follows:
janga_main_source_platform_test_log_11_28.txt
janga_main_source_sensor_test_log_11_28.txt