Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meru800: fix SCM_ECB_VIN sensor thresholds #276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Meru800: fix SCM_ECB_VIN sensor thresholds #276

wants to merge 1 commit into from

Conversation

aalamsi22
Copy link
Contributor

Description

SCM_ECB_VIN is reporting thersholds exceeded. The thresholds are not correct:

SCM_ECB_VIN 11.906250 2024-10-16 11:45:51.0 PDT 3.960000 2.640000 VOLTAGE Critical

This PR updates the thresholds to the following (ECB is a 12V device):

        "thresholds": {
          "upperCriticalVal": 14.4,
          "lowerCriticalVal": 10.5
        },

@facebook-github-bot
Copy link
Contributor

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@aalamsi22 aalamsi22 mentioned this pull request Nov 2, 2024
Closed
facebook-github-bot pushed a commit that referenced this pull request Dec 5, 2024
@aalamsi22 @facebook-github-bot
meru800: Remove SCM VRM monitoring (#286)
130d3c0 
Summary:
# Description

The VRM readings on the SCM are not stable and should not be monitored as they will throw false alarms. This PR removes monitoring of those VRM devices on the SCM. Note that the devices will still be supported and can be accessed via sysfs.

+PR also includes threshold correction from this PR: #276
+meru800biab includes change to sync PSU pmUnitName with that of meru800bia

Pull Request resolved: #286

Reviewed By: somasun

Differential Revision: D65791490

Pulled By: joancaneus

fbshipit-source-id: b53e2c37a908b7cb58b598bfb91575532f6f63f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalamsi22 @facebook-github-bot