-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: add DARWIN48V platform definition #257
Open
adamcalabrigo
wants to merge
3
commits into
facebook:main
Choose a base branch
from
adamcalabrigo:darwin48v_platform_0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2024
@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
harshitgulati18
approved these changes
Oct 14, 2024
@adamcalabrigo has updated the pull request. You must reimport the pull request before landing. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
Summary: # Description Adds initial `platform_manager` support for `DARWIN48V` platform. Note that this depends on the changes in #257. Pull Request resolved: #260 Test Plan: FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4. Verified on DARWIN48V hardware. The `platform_manager` service loads correctly: ``` # systemctl status platform_manager ● platform_manager.service - FBOSS Platform Manager Loaded: loaded (/etc/systemd/system/platform_manager.service; enabled; preset: disabled) Active: active (running) since Tue 2024-10-08 00:39:22 UTC; 1h 36min ago Process: 4744 ExecStartPre=/bin/bash -c [[ -f /opt/fboss/share/platform_configs/platform_manager.json ]] (code=exited, status=0/SUCCESS) Main PID: 4745 (platform_manage) Reviewed By: kimdo8736 Differential Revision: D64087926 Pulled By: joancaneus fbshipit-source-id: 93d72214d5fe06052b0b8c20546e670fb69b82f3
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Summary: # Description Adds initial `weutil` config for `DARWIN48V` platform. The offset for the `CHASSIS` EEPROM is not a typo: we use a smaller offset because the memory is physically smaller. Note that this depends on the changes in #257. Pull Request resolved: #262 Test Plan: FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4. Validated on DARWIN48V hardware with all targets. e.g. chassis: ``` # weutil -eeprom chassis Version: 5 Product Name: DARWIN48V ... CRC16: 0x1553 (CRC Matched) ``` Reviewed By: Scott8440 Differential Revision: D64087892 Pulled By: joancaneus fbshipit-source-id: 4460f0070e233e676e7b03070f0d57925866d7dd
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Summary: # Description Adds initial `fan_service` support for `DARWIN48V` platform. The config is the same as `DARWIN`, but fan6 has been restored to the config and it's PWM is now set correctly due to updates in BSP. Note that this depends on the changes in #257. Pull Request resolved: #264 Test Plan: FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4. Validated on DARWIN48V hardware. `fan_service` loads correctly: ``` # systemctl status fan_service ● fan_service.service - Start fan_service Loaded: loaded (/etc/systemd/system/fan_service.service; enabled; preset: disabled) Active: active (running) since Tue 2024-10-08 00:39:22 UTC; 2h 23min ago Main PID: 4939 (run_fan_service) Reviewed By: Scott8440 Differential Revision: D64087857 Pulled By: joancaneus fbshipit-source-id: 9d3e4a621d7e8757b7aec4645252e6074ee94fdd
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Summary: # Description Adds initial `sensor_service` support for `DARWIN48V` platform. Note that this depends on the changes in #257. Monitored sensors are the same as `DARWIN` platform with the exception of PSU replacing PEM. Pull Request resolved: #261 Test Plan: FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4. Validated on DARWIN48V hardware. The `sensor_service` loads correctly: ``` # systemctl status sensor_service ● sensor_service.service - Start sensor_service Loaded: loaded (/etc/systemd/system/sensor_service.service; enabled; preset: disabled) Active: active (running) since Tue 2024-10-08 00:39:22 UTC; 1h 49min ago Main PID: 4894 (run_sensor_serv) Reviewed By: kimdo8736 Differential Revision: D64087915 Pulled By: joancaneus fbshipit-source-id: bca8f81599b205e9815918e9803122e09bb07de9
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Summary: # Description Adds `DARWIN48V` platform references to qsfp_service. Note that this depends on the changes in #257. Pull Request resolved: #259 Test Plan: FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4. qsfp_service code untested on HW. Reviewed By: kimdo8736 Differential Revision: D64087960 Pulled By: joancaneus fbshipit-source-id: 6e8bfaeda5c618ecbf101c382292aec60c8fd6a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
DARWIN48V
platform definition to lib platform init logic. Note that value36
is used in enum due to conflict with #253.Test Plan
FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4.
Platform name maps correctly: