Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add DARWIN48V platform definition #257

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adamcalabrigo
Copy link
Contributor

Description

Adds DARWIN48V platform definition to lib platform init logic. Note that value 36 is used in enum due to conflict with #253.

Test Plan

FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4.

Platform name maps correctly:

platform_manager[4745]: I1008 00:39:13.176679  4745 PlatformNameLib.cpp:58] Platform name inferred from bios: DARWIN48V
platform_manager[4745]: I1008 00:39:13.176695  4745 PlatformNameLib.cpp:60] Platform name mapped: DARWIN48V

@facebook-github-bot
Copy link
Contributor

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@adamcalabrigo has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot pushed a commit that referenced this pull request Dec 3, 2024
Summary:
# Description

Adds initial `platform_manager` support for `DARWIN48V` platform. Note that this depends on the changes in #257.

Pull Request resolved: #260

Test Plan:
FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4.

Verified on DARWIN48V hardware.

The `platform_manager` service loads correctly:
```
# systemctl status platform_manager
● platform_manager.service - FBOSS Platform Manager
     Loaded: loaded (/etc/systemd/system/platform_manager.service; enabled; preset: disabled)
     Active: active (running) since Tue 2024-10-08 00:39:22 UTC; 1h 36min ago
    Process: 4744 ExecStartPre=/bin/bash -c [[ -f /opt/fboss/share/platform_configs/platform_manager.json ]] (code=exited, status=0/SUCCESS)
   Main PID: 4745 (platform_manage)

Reviewed By: kimdo8736

Differential Revision: D64087926

Pulled By: joancaneus

fbshipit-source-id: 93d72214d5fe06052b0b8c20546e670fb69b82f3
facebook-github-bot pushed a commit that referenced this pull request Dec 4, 2024
Summary:
# Description

Adds initial `weutil` config for `DARWIN48V` platform. The offset for the `CHASSIS` EEPROM is not a typo: we use a smaller offset because the memory is physically smaller.

Note that this depends on the changes in #257.

Pull Request resolved: #262

Test Plan:
FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4.

Validated on DARWIN48V hardware with all targets.

e.g. chassis:
```
# weutil -eeprom chassis
Version: 5
Product Name: DARWIN48V
...
CRC16: 0x1553 (CRC Matched)
```

Reviewed By: Scott8440

Differential Revision: D64087892

Pulled By: joancaneus

fbshipit-source-id: 4460f0070e233e676e7b03070f0d57925866d7dd
facebook-github-bot pushed a commit that referenced this pull request Dec 4, 2024
Summary:
# Description

Adds initial `fan_service` support for `DARWIN48V` platform. The config is the same as `DARWIN`, but fan6 has been restored to the config and it's PWM is now set correctly due to updates in BSP.

Note that this depends on the changes in #257.

Pull Request resolved: #264

Test Plan:
FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4.

Validated on DARWIN48V hardware.

`fan_service` loads correctly:
```
# systemctl status  fan_service
● fan_service.service - Start fan_service
     Loaded: loaded (/etc/systemd/system/fan_service.service; enabled; preset: disabled)
     Active: active (running) since Tue 2024-10-08 00:39:22 UTC; 2h 23min ago
   Main PID: 4939 (run_fan_service)

Reviewed By: Scott8440

Differential Revision: D64087857

Pulled By: joancaneus

fbshipit-source-id: 9d3e4a621d7e8757b7aec4645252e6074ee94fdd
facebook-github-bot pushed a commit that referenced this pull request Dec 4, 2024
Summary:
# Description
Combines #257, #258 and  #263.

#263 fails builds due to a dependencies found in #257 and  #258.

Pull Request resolved: #293

Reviewed By: somasun, mikechoifb

Differential Revision: D65801211

Pulled By: joancaneus

fbshipit-source-id: 2724e1073e2369fe802c4d144555ce93e95e6c6f
facebook-github-bot pushed a commit that referenced this pull request Dec 5, 2024
Summary:
# Description

Adds initial `sensor_service` support for `DARWIN48V` platform. Note that this depends on the changes in #257. Monitored sensors are the same as `DARWIN` platform with the exception of PSU replacing PEM.

Pull Request resolved: #261

Test Plan:
FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4.

Validated on DARWIN48V hardware.

The `sensor_service` loads correctly:
```
# systemctl status sensor_service
● sensor_service.service - Start sensor_service
     Loaded: loaded (/etc/systemd/system/sensor_service.service; enabled; preset: disabled)
     Active: active (running) since Tue 2024-10-08 00:39:22 UTC; 1h 49min ago
   Main PID: 4894 (run_sensor_serv)

Reviewed By: kimdo8736

Differential Revision: D64087915

Pulled By: joancaneus

fbshipit-source-id: bca8f81599b205e9815918e9803122e09bb07de9
facebook-github-bot pushed a commit that referenced this pull request Dec 5, 2024
Summary:
# Description

Adds `DARWIN48V` platform references to qsfp_service. Note that this depends on the changes in #257.

Pull Request resolved: #259

Test Plan:
FBOSS OSS build passes with CentOS 9 and Linux kernel 6.4.

qsfp_service code untested on HW.

Reviewed By: kimdo8736

Differential Revision: D64087960

Pulled By: joancaneus

fbshipit-source-id: 6e8bfaeda5c618ecbf101c382292aec60c8fd6a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants