Skip to content

Commit

Permalink
Allow more time for ports to come up after qsfp service cold boot
Browse files Browse the repository at this point in the history
Summary:
We are currently waiting only 1min for ports to come up after cold-booting qsfp service. This is causing flakiness in tests. This was exposed by D67580376 which optimizes waitForAllCabledPorts implementation.

Our overall expectation is for services to stablize and ports to come up within 5mins. Matching that in the test too

Reviewed By: birdsoup

Differential Revision: D67885054

fbshipit-source-id: 35451c263df0076fe74f2519c7ed988dfdb3b6c6
  • Loading branch information
Harshit Gulati authored and facebook-github-bot committed Jan 7, 2025
1 parent 1302673 commit c73270b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fboss/agent/test/link_tests/LinkSanityTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ TEST_F(LinkTest, qsfpColdbootAfterAgentUp) {
/* sleep override */
sleep(5);
// Assert all cabled ports are up and transceivers have ACTIVE state
EXPECT_NO_THROW(waitForAllCabledPorts(true));
EXPECT_NO_THROW(waitForAllCabledPorts(true, 60, 5s));
EXPECT_NO_THROW(utility::waitForAllTransceiverStates(
true, getCabledTranceivers(), 60, 5s));
});
Expand Down

0 comments on commit c73270b

Please sign in to comment.