Skip to content

Commit a94088a

Browse files
mszabo-wikiafacebook-github-bot
authored andcommitted
Add fbcode_builder manifests for mcrouter and ragel
Summary: X-link: facebookincubator/zstrong#944 https://github.com/facebook/mcrouter currently uses a legacy autotools-based build system, which forces third parties to rely on a collection of scripts hosted in the repository to build it with all required dependencies. This is brittle and has lead to many issue reports about build problems. In facebook/mcrouter#449, I've prepared a working CMake-based build system for mcrouter that could replace the legacy autotools setup. This patch adds the necessary manifests for mcrouter and its ragel dependency so that fbcode_builder itself will be setup for the repo without having to do it in the PR. X-link: facebook/folly#2268 Reviewed By: yfeldblum Differential Revision: D60537337 Pulled By: Orvid fbshipit-source-id: ed73693d4af93acc3b8e996a7c61d0090075949f
1 parent 83298ae commit a94088a

File tree

2 files changed

+42
-0
lines changed

2 files changed

+42
-0
lines changed
+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
[manifest]
2+
name = mcrouter
3+
4+
[git]
5+
repo_url = https://github.com/facebook/mcrouter.git
6+
7+
[dependencies]
8+
folly
9+
wangle
10+
fizz
11+
fbthrift
12+
mvfst
13+
ragel
14+
15+
[build]
16+
builder = cmake
17+
subdir = .
18+
19+
[cmake.defines.test=on]
20+
BUILD_TESTS=ON
21+
22+
[cmake.defines.test=off]
23+
BUILD_TESTS=OFF

build/fbcode_builder/manifests/ragel

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
[manifest]
2+
name = ragel
3+
4+
[debs]
5+
ragel
6+
7+
[homebrew]
8+
ragel
9+
10+
[rpms]
11+
ragel
12+
13+
[download]
14+
url = https://www.colm.net/files/ragel/ragel-6.10.tar.gz
15+
sha256 = 5f156edb65d20b856d638dd9ee2dfb43285914d9aa2b6ec779dac0270cd56c3f
16+
17+
[build]
18+
builder = autoconf
19+
subdir = ragel-6.10

0 commit comments

Comments
 (0)