Skip to content

Excluded categories | Bring back the modal and fixing warning#3436

Merged
vahidkay-meta merged 3 commits intofacebook:release/3.5.3from
SayanPandey:release/3.5.3_fixes_for_warnings_and_categories
Jun 18, 2025
Merged

Excluded categories | Bring back the modal and fixing warning#3436
vahidkay-meta merged 3 commits intofacebook:release/3.5.3from
SayanPandey:release/3.5.3_fixes_for_warnings_and_categories

Conversation

@SayanPandey
Copy link
Copy Markdown
Contributor

Description

Fixes for the release branch for log warning and excluded category

Type of change

Fix

Checklist

  • I have commented my code, particularly in hard-to-understand areas, if any.
  • I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
  • I followed general Pull Request best practices. Meta employees to follow this wiki.
  • [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
  • I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

@SayanPandey SayanPandey changed the title Revert "Removing unnecessary modal for excluded categories (#3307)" Excluded categories | Bring back the modal and fixing warning Jun 18, 2025
Comment thread includes/AJAX.php Outdated
@vahidkay-meta vahidkay-meta merged commit 70bd738 into facebook:release/3.5.3 Jun 18, 2025
7 checks passed
@SayanPandey SayanPandey deleted the release/3.5.3_fixes_for_warnings_and_categories branch June 18, 2025 14:42
@SayanPandey SayanPandey restored the release/3.5.3_fixes_for_warnings_and_categories branch June 18, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants