Skip to content

Fixed the process to share ExternalVersionUpdate with Meta #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vinkmeta wants to merge 4 commits into from
Closed

Fixed the process to share ExternalVersionUpdate with Meta #3365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bef0945
Fixed the process to share ExternalVersionUpdate with Meta
vinkmeta Jun 13, 2025
6639a8c
Fixed failing tests
vinkmeta Jun 13, 2025
4fc1c74
Fixed test
vinkmeta Jun 13, 2025
3354bd5
Merge branch 'main' into vink_1
vinkmeta Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 9 additions & 30 deletions includes/ExternalVersionUpdate/Update.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,49 +36,28 @@ class Update {
* @since 3.0.10
*/
public function __construct() {
add_action( Heartbeat::DAILY, array( $this, 'maybe_update_external_plugin_version' ) );
add_action( Heartbeat::DAILY, array( $this, 'send_new_version_to_facebook_server' ) );
}

/**
* Check if we need to inform the Meta server of a new version.
* Sends the latest plugin version to the Meta server.
*
* @since 3.0.10
* @return bool
*/
public function maybe_update_external_plugin_version() {
if ( ! $this->should_update_version() ) {
return false;
}

return $this->send_new_version_to_facebook_server();
}
public function send_new_version_to_facebook_server() {

/**
* Checks if the plugin version needs to be updated.
*
* @since 3.0.10
* @return bool
*/
public function should_update_version() {
$plugin = facebook_for_woocommerce();

if ( ! $plugin->get_connection_handler()->is_connected() ) {
// If the plugin is not connected, we don't need to send the version to the Meta server.
return false;
return;
}

return true;
}

/**
* Sends the latest plugin version to the Meta server.
*
* @since 3.0.10
* @return bool
*/
public function send_new_version_to_facebook_server() {

$plugin = facebook_for_woocommerce();
$flag_name = '_wc_facebook_for_woocommerce_external_version_update_flag';
if ( 'yes' === get_transient( $flag_name ) ) {
return;
}
set_transient( $flag_name, 'yes', 12 * HOUR_IN_SECONDS );

// Send the request to the Meta server with the latest plugin version.
try {
Expand Down
66 changes: 2 additions & 64 deletions tests/Unit/ExternalVersionUpdate/UpdateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,50 +88,10 @@ public function tearDown():void {
parent::tearDown();
}

/**
* Test should_update_version
*/
public function test_should_update_version() {
$plugin = facebook_for_woocommerce();
/**
* Set the $plugin->connection_handler and $plugin->api access to true. This will allow us
* to assign the mock objects to these properties.
*/
$plugin_ref_obj = new ReflectionObject( $plugin );
$prop_connection_handler = $plugin_ref_obj->getProperty( 'connection_handler' );
$prop_connection_handler->setAccessible( true );

// Connection Handler mock object to return is_connected as false.
$mock_connection_handler = $this->getMockBuilder( Connection::class )
->disableOriginalConstructor()
->setMethods( array( 'is_connected' ) )
->getMock();
$mock_connection_handler->expects( $this->any() )->method( 'is_connected' )->willReturn( false );
$prop_connection_handler->setValue( $plugin, $mock_connection_handler );
update_option( 'facebook_for_woocommerce_latest_version_sent_to_server', '0.0.0' ); // Reset the option.
$should_update2 = $this->update->should_update_version();
$this->assertFalse( $should_update2 );

// Connection Handler mock object to return is_connected as true.
$mock_connection_handler = $this->getMockBuilder( Connection::class )
->disableOriginalConstructor()
->setMethods( array( 'is_connected' ) )
->getMock();
$mock_connection_handler->expects( $this->any() )->method( 'is_connected' )->willReturn( true );
$prop_connection_handler->setValue( $plugin, $mock_connection_handler );
update_option( 'facebook_for_woocommerce_latest_version_sent_to_server', WC_Facebookcommerce_Utils::PLUGIN_VERSION );
$should_update3 = $this->update->should_update_version();
$this->assertTrue( $should_update3 ); // Because the versions match.

update_option( 'facebook_for_woocommerce_latest_version_sent_to_server', '0.0.0' ); // Reset the option.
$should_update4 = $this->update->should_update_version();
$this->assertTrue( $should_update4 );
}

/**
* Test send new version to facebook.
*/
public function test_maybe_update_external_plugin_version() {
public function test_send_new_version_to_facebook_server() {
$plugin = facebook_for_woocommerce();
$plugin->init_admin();

Expand Down Expand Up @@ -179,7 +139,7 @@ public function test_maybe_update_external_plugin_version() {
);
$prop_api->setValue( $plugin, $mock_api );

$updated = $this->update->maybe_update_external_plugin_version();
$updated = $this->update->send_new_version_to_facebook_server();

// Assert request data.
$expected_request = array(
Expand All @@ -203,41 +163,19 @@ public function test_maybe_update_external_plugin_version() {
$this->assertTrue( $updated, 'Failed asserting that the update plugin request was made.' );
$this->assertEquals( WC_Facebookcommerce_Utils::PLUGIN_VERSION, get_option( 'facebook_for_woocommerce_latest_version_sent_to_server' ), 'Failed asserting that latest version sent to server is the same as the plugin version.' );

// For the subsequent request, no update request should be made.
$updated_second_time = $this->update->maybe_update_external_plugin_version();
$this->assertFalse( $updated_second_time, 'Failed asserting that the update plugin request was not made.' );

// Now the mock API object will return a WP_Error.
$mock_api2 = $this->getMockBuilder( API::class )->disableOriginalConstructor()->setMethods( array( 'do_remote_request' ) )->getMock();
$mock_api2->expects( $this->any() )->method( 'do_remote_request' )->willReturn( new WP_Error( 'dummy-code', 'dummy-message', array( 'data' => 'dummy data' ) ) );
$prop_api->setValue( $plugin, $mock_api2 );

// Assert handling failed API response.
update_option( 'facebook_for_woocommerce_latest_version_sent_to_server', '0.0.0' ); // Reset the version to pass the should_update_version check.
$updated3 = $this->update->maybe_update_external_plugin_version();
$this->assertFalse( $updated3 ); // API failed response is handled.
$this->assertNotEquals( WC_Facebookcommerce_Utils::PLUGIN_VERSION, get_option( 'facebook_for_woocommerce_latest_version_sent_to_server' ) ); // API failed response should not update the option.

// Now the mock API object will throw a Plugin Exception.
$mock_api3 = $this->getMockBuilder( API::class )->disableOriginalConstructor()->setMethods( array( 'perform_request' ) )->getMock();
$mock_api3->expects( $this->any() )->method( 'perform_request' )->willThrowException( new PluginException( 'Dummy Plugin Exception' ) );
$prop_api->setValue( $plugin, $mock_api3 );

// Assert PluginException Handling.
update_option( 'facebook_for_woocommerce_latest_version_sent_to_server', '0.0.0' ); // Reset the version to pass the should_update_version check.
$updated4 = $this->update->maybe_update_external_plugin_version();
$this->assertFalse( $updated4 ); // API failed response is handled.
$this->assertNotEquals( WC_Facebookcommerce_Utils::PLUGIN_VERSION, get_option( 'facebook_for_woocommerce_latest_version_sent_to_server' ) ); // API failed response should not update the option.

// Now the mock API object will throw an ApiException.
$mock_api4 = $this->getMockBuilder( API::class )->disableOriginalConstructor()->setMethods( array( 'perform_request' ) )->getMock();
$mock_api4->expects( $this->any() )->method( 'perform_request' )->willThrowException( new ApiException( 'Dummy API Exception' ) );
$prop_api->setValue( $plugin, $mock_api4 );

// Assert ApiException Handling.
update_option( 'facebook_for_woocommerce_latest_version_sent_to_server', '0.0.0' ); // Reset the version to pass the should_update_version check.
$updated5 = $this->update->maybe_update_external_plugin_version();
$this->assertFalse( $updated5 ); // API failed response is handled.
$this->assertNotEquals( WC_Facebookcommerce_Utils::PLUGIN_VERSION, get_option( 'facebook_for_woocommerce_latest_version_sent_to_server' ) ); // API failed response should not update the option.
}
}