Skip to content

Tracking error messages being displayed to Admins #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vinkmeta wants to merge 4 commits into from
Closed

Tracking error messages being displayed to Admins #3345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e93289
Tracking error messages being displayed to Admins
vinkmeta Jun 11, 2025
c7fe01e
Fixed typo
vinkmeta Jun 11, 2025
2624a03
Fixed failing tests
vinkmeta Jun 11, 2025
a38ba3e
typo
vinkmeta Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions facebook-commerce.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2855,10 +2855,18 @@ public function maybe_display_facebook_api_messages() {
// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
echo $this->get_message_html( $message );
delete_transient( 'facebook_plugin_api_error' );
WC_Facebookcommerce_Utils::fblog(
$error_msg,
[],
true
Logger::log(
'Error message displayed to Admins',
array(
'flow_name' => 'display_admin_message',
'flow_step' => 'display_admin_error_message',
'extra_data' => [
'displayed_message' => $error_msg,
],
),
array(
'should_send_log_to_meta' => true,
)
);
}
$warning_msg = get_transient( 'facebook_plugin_api_warning' );
Expand Down
4 changes: 2 additions & 2 deletions includes/Logger/Logger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ public static function log($message, $context = [], $log_options = [
'woocommerce_log_level' => \WC_Log_Levels::DEBUG,
]) {
$is_debug_mode_enabled = 'yes' === get_option( self::SETTING_ENABLE_META_DIAGNOSIS );
if ( $is_debug_mode_enabled && $log_options['should_save_log_in_woocommerce'] ) {
if ( $is_debug_mode_enabled && array_key_exists( 'should_save_log_in_woocommerce', $log_options ) && $log_options['should_save_log_in_woocommerce'] ) {
facebook_for_woocommerce()->log( $message . ' : ' . wp_json_encode( $context ), null, $log_options['woocommerce_log_level'] );
}

$is_meta_diagnosis_enabled = (bool) ( 'yes' === get_option( self::SETTING_ENABLE_META_DIAGNOSIS ) );
if ( $log_options['should_send_log_to_meta'] && $is_meta_diagnosis_enabled ) {
if ( $is_meta_diagnosis_enabled && array_key_exists( 'should_send_log_to_meta', $log_options ) && $log_options['should_send_log_to_meta'] ) {

$extra_data = $context['extra_data'] ?? [];
$extra_data['message'] = $message;
Expand Down