Skip to content

Enabled fbproduct for code sniffing #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vinkmeta wants to merge 2 commits into from
Closed

Enabled fbproduct for code sniffing #3328

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
827cb00
Enabled fbproduct for code sniffing
vinkmeta Jun 10, 2025
39ef927
Merge branch 'main' into vink_2
vinkmeta Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 30 additions & 34 deletions includes/fbproduct.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?php
// phpcs:ignoreFile
/**
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved
*
Expand All @@ -12,7 +11,6 @@
require_once __DIR__ . '/fbutils.php';

use WooCommerce\Facebook\Feed\ShippingProfilesFeed;
use WooCommerce\Facebook\Framework\Plugin\Compatibility;
use WooCommerce\Facebook\Framework\Helper;
use WooCommerce\Facebook\Handlers\PluginRender;
use WooCommerce\Facebook\Products;
Expand Down Expand Up @@ -214,7 +212,7 @@ public function get_unmapped_attributes() {
if ( ! empty( $value ) ) {
$mapped_field = $this->check_attribute_mapping( $attribute_name );

if ( $mapped_field === false ) {
if ( false === $mapped_field ) {
$unmapped_attributes[] = array(
'name' => $attribute_name,
'value' => $value,
Expand Down Expand Up @@ -242,7 +240,8 @@ public function __construct( $wpid, $parent_product = null ) {
$this->main_description = '';
$this->rich_text_description = '';

if ( $meta = get_post_meta( $this->id, self::FB_VISIBILITY, true ) ) {
if ( get_post_meta( $this->id, self::FB_VISIBILITY, true ) ) {
$meta = get_post_meta( $this->id, self::FB_VISIBILITY, true );
$this->fb_visibility = wc_string_to_bool( $meta );
} else {
$this->fb_visibility = '';
Expand Down Expand Up @@ -278,18 +277,15 @@ public function __get( $key ) {
}

public function exists() {
return ( $this->woo_product !== null && $this->woo_product !== false );
return ( null !== $this->woo_product && false !== $this->woo_product );
}

// Fall back to calling method on $woo_product
public function __call( $function, $args ) {
public function __call( $func, $args ) {
if ( $this->woo_product ) {
return call_user_func_array( array( $this->woo_product, $function ), $args );
return call_user_func_array( array( $this->woo_product, $func ), $args );
} else {
$e = new Exception();
$backtrace = var_export( $e->getTraceAsString(), true );
WC_Facebookcommerce_Utils::fblog(
"Calling $function on Null Woo Object. Trace:\n" . $backtrace,
"Calling $func on Null Woo Object.\n",
array(),
true
);
Expand All @@ -298,7 +294,7 @@ public function __call( $function, $args ) {
}

public function get_gallery_urls() {
if ( $this->gallery_urls === null ) {
if ( null === $this->gallery_urls ) {
if ( is_callable( array( $this, 'get_gallery_image_ids' ) ) ) {
$image_ids = $this->get_gallery_image_ids();
} else {
Expand Down Expand Up @@ -378,8 +374,8 @@ public function get_all_image_urls() {

if ( $this->woo_product->is_type( 'variation' ) ) {

if ( $parent_product = wc_get_product( $this->woo_product->get_parent_id() ) ) {

if ( wc_get_product( $this->woo_product->get_parent_id() ) ) {
$parent_product = wc_get_product( $this->woo_product->get_parent_id() );
$parent_product_image_url = wp_get_attachment_image_url( $parent_product->get_image_id(), $image_size );
}
}
Expand Down Expand Up @@ -418,14 +414,15 @@ public function get_all_image_urls() {
/**
* Gets a list of video URLs to use for this product in Facebook sync.
*
* @param mixed $parent_id
* @return array
*/
public function get_all_video_urls( $parent_id = null ) {

$video_urls = array();
$product = $this->woo_product;

if ( $parent_id !== null ) {
if ( null !== $parent_id ) {
$product = wc_get_product( $parent_id );
}

Expand Down Expand Up @@ -480,7 +477,7 @@ private function get_additional_image_urls( $image_urls ) {
}


// Returns the parent image id for variable products only.
/** Returns the parent image id for variable products only. */
public function get_parent_image_id() {
if ( WC_Facebookcommerce_Utils::is_variation_type( $this->woo_product->get_type() ) ) {
$parent_data = $this->get_parent_data();
Expand All @@ -500,7 +497,7 @@ public function set_description( $description ) {
}

public function set_product_image( $image ) {
if ( $image !== null && strlen( $image ) !== 0 ) {
if ( null !== $image && 0 !== strlen( $image ) ) {
$image = WC_Facebookcommerce_Utils::clean_string( $image );
$image = WC_Facebookcommerce_Utils::make_url( $image );
update_post_meta(
Expand Down Expand Up @@ -614,7 +611,7 @@ public function set_price( $price ) {
}

public function get_use_parent_image() {
if ( $this->fb_use_parent_image === null ) {
if ( null === $this->fb_use_parent_image ) {
$variant_image_setting =
get_post_meta( $this->id, self::FB_VARIANT_IMAGE, true );
$this->fb_use_parent_image = ( $variant_image_setting ) ? true : false;
Expand All @@ -623,7 +620,7 @@ public function get_use_parent_image() {
}

public function set_use_parent_image( $setting ) {
$this->fb_use_parent_image = ( $setting === 'yes' );
$this->fb_use_parent_image = ( 'yes' === $setting );
update_post_meta(
$this->id,
self::FB_VARIANT_IMAGE,
Expand Down Expand Up @@ -921,23 +918,25 @@ public function add_sale_price( $product_data, $for_items_batch = false ) {

// check if sale exist
if ( is_numeric( $sale_price ) && $sale_price > 0 ) {
$sale_start =
( $date = $this->woo_product->get_date_on_sale_from() )
? date_i18n( WC_DateTime::ATOM, $date->getOffsetTimestamp() )
$sale_start = $this->woo_product->get_date_on_sale_from();
$sale_start =
$sale_start
? date_i18n( WC_DateTime::ATOM, $sale_start->getOffsetTimestamp() )
: self::MIN_DATE_1 . self::MIN_TIME;
$sale_end =
( $date = $this->woo_product->get_date_on_sale_to() )
? date_i18n( WC_DateTime::ATOM, $date->getOffsetTimestamp() )
$sale_end = $this->woo_product->get_date_on_sale_to();
$sale_end =
$sale_end
? date_i18n( WC_DateTime::ATOM, $sale_end->getOffsetTimestamp() )
: self::MAX_DATE . self::MAX_TIME;
$sale_price_effective_date =
( $sale_start == self::MIN_DATE_1 . self::MIN_TIME && $sale_end == self::MAX_DATE . self::MAX_TIME )
( self::MIN_DATE_1 . self::MIN_TIME === $sale_start && self::MAX_DATE . self::MAX_TIME === $sale_end )
? ''
: $sale_start . '/' . $sale_end;
$sale_price =
intval( round( $this->get_price_plus_tax( $sale_price ) * 100 ) );

// Set Sale start and end as empty if set to default values
if ( $sale_start == self::MIN_DATE_1 . self::MIN_TIME && $sale_end == self::MAX_DATE . self::MAX_TIME ) {
if ( self::MIN_DATE_1 . self::MIN_TIME === $sale_start && self::MAX_DATE . self::MAX_TIME === $sale_end ) {
$sale_start = '';
$sale_end = '';
}
Expand Down Expand Up @@ -1017,7 +1016,7 @@ public function get_fb_condition() {
// Extract first value from array or object
$fb_condition = $this->get_first_value_from_complex_type( $fb_condition );

return WC_Facebookcommerce_Utils::clean_string( $fb_condition ) ?: self::CONDITION_NEW;
return WC_Facebookcommerce_Utils::clean_string( $fb_condition ) ? WC_Facebookcommerce_Utils::clean_string( $fb_condition ) : self::CONDITION_NEW;
}


Expand All @@ -1028,7 +1027,7 @@ public function get_fb_age_group() {

foreach ( $attributes as $key => $value ) {
$attr_key = strtolower( $key );
if ( $attr_key === 'age_group' ) {
if ( 'age_group' === $attr_key ) {
// Extract first value from array or object for attribute
$value = $this->get_first_value_from_complex_type( $value );
return WC_Facebookcommerce_Utils::clean_string( $value );
Expand Down Expand Up @@ -1070,7 +1069,7 @@ public function get_fb_gender() {

foreach ( $attributes as $key => $value ) {
$attr_key = strtolower( $key );
if ( $attr_key === 'gender' ) {
if ( 'gender' === $attr_key ) {
// Extract first value from array or object for attribute
$value = $this->get_first_value_from_complex_type( $value );
return WC_Facebookcommerce_Utils::clean_string( $value );
Expand Down Expand Up @@ -1206,12 +1205,9 @@ private function get_taxonomy_attribute_values( $attribute_name ) {
if ( ! empty( $attribute_value ) ) {
return array( $attribute_value );
}

// If no specific value, try parent product
return $this->get_parent_taxonomy_attribute_values( $attribute_name );
}
// For regular products
elseif ( $attribute_found && $attribute_obj ) {
} elseif ( $attribute_found && $attribute_obj ) { // For regular products
if ( $attribute_obj->is_taxonomy() ) {
$terms = $attribute_obj->get_terms();
if ( $terms && ! is_wp_error( $terms ) ) {
Expand Down