Fix non-static method reset_upcoming_version_banners called by WP Hook#3292
Closed
carterbuce wants to merge 1 commit intofacebook:mainfrom
Closed
Fix non-static method reset_upcoming_version_banners called by WP Hook#3292carterbuce wants to merge 1 commit intofacebook:mainfrom
carterbuce wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@carterbuce merged this pull request in 3160c53. |
carterbuce
added a commit
that referenced
this pull request
Jun 3, 2025
#3292) Summary: ## Description We got an report from QA of an error log being surfaced due to this non-static method being called in a static way. This is similar to some other errors we've seen and fixed recently. Updating the method to be static to resolve the error. https://privatebin.net/?7272b8875ee5971f#9fkC642u6APEjm6TQsYoD6jLrW1MEvrkGQDvwUaQJuYZ ### Type of change Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## Checklist - [] I have commented my code, particularly in hard-to-understand areas. - [] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Fix non-static method reset_upcoming_version_banners called by WP Hook Pull Request resolved: #3292 Reviewed By: nrostrow-meta Differential Revision: D75900200 Pulled By: carterbuce fbshipit-source-id: 1abe21f61d1916feceaf9181577f9ce049d41a01 (cherry picked from commit 3160c53)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We got an report from QA of an error log being surfaced due to this non-static method being called in a static way. This is similar to some other errors we've seen and fixed recently. Updating the method to be static to resolve the error.
https://privatebin.net/?7272b8875ee5971f#9fkC642u6APEjm6TQsYoD6jLrW1MEvrkGQDvwUaQJuYZ
Type of change
Please delete options that are not relevant.
Checklist
Changelog entry
Fix non-static method reset_upcoming_version_banners called by WP Hook