Fix inconsistency between enhanced and legacy flow

[jczhuoMeta]

TL;DR

We found some issue caused by the inconsistency between the legacy and enhanced flow. The real world uses are unlikely to have the same serious issues. This PR put out a graceful fix it them.

Description

During dogfooding and QA testing, we get reports of:

1. Should show legacy view but rendered with BROKEN MiCE page
2. Used the enhanced flow onboard but seeing the legacy view after onboarding.

The causes has been identified as:

1. The CPI ID didn't get cleared out when off boarding using legacy flow.
   This has been fixed in https://github.com/facebook/facebook-for-woocommerce/pull/3262/files but for existing instances off boarded before the fix landed, it's still experience problems
2. Some fields(e.g. business id) were missed during saving the onboarding result, causing MiCE failed to render.

Issue 1

It's mainly impacting QA and internal users, for public users, the only chance they have a stale CPI ID and seeing this issue only if the performed the exact actions:

1. They upgraded to 3.4.8, the CPI was repaired in the background.
2. They disconnected their shop, staled CPI stay in their DB
3. They reconnected their shop
4. They upgraded 3.5.0, staled CPI causing their MiCE rendering to be all broken

However, since this will cause broken MiCE page, this PR introduces graceful and robust logic to ensure the CPI is correct:
a. Using MBE response as source of truth, if the response from Meta does not have CPI ID, then clear the local CPI ID. This ensures no stale CPI ID.
b. The CPI repair endpoint will fetch or repair, get the correct CPI ID
The logic is implemented in refresh_installation_data heartbeat will fix the data inconsistency automatically.

Issue 2

It wasn't surfaced frequently as the refresh_installation_data is also repairing the missing IDs in the background. This PR added the saving action of those missing fields.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have commented my code, particularly in hard-to-understand areas.
• I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
• I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
• I followed general Pull Request best practices. Meta employees to follow this wiki.
• I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
• I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
• I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

Changelog entry

Fix onboarding and offboarding data inconsistency between legacy and enhanced connection view.

Test Plan

No unit test can cover it since it's caused by a sequence of actions.
All existing tests passes:

Time: 00:28.917, Memory: 121.00 MB
OK (324 tests, 859 assertions)

Manual test it to cover all the cases.

Before

Verify on 3.5.0 branch, the business manager id was missing:

The cpi id exists:

and should be cleaned during uninstall since current 3.5.0 already included the cleanup fix(https://github.com/facebook/facebook-for-woocommerce/pull/3262/files), however, still manually make a copy so we can verify a lingering cpi_id won't break things.

After

Disconnect and switch to the current branch:
After onboarding, we now have business ID populated:

Now use the wrong CPI id to make sure the installation can recover:

1. Use the previously saved, 2153153801813487 to overwrite wc_facebook_commerce_partner_integration_id, 729123966146427, intentionally put a stall cpi_id in the field.

6. Go to Meta side and manually delete the correct CPI 729123966146427
   The Overview page broken as expected, mimicking the staled CPI ID cases

7. Run update_installation_data

This removed staled CPI ID The legacy view is showing as expected

8. Run repair to create a new CPI

Now the MiCE is rendering poperly

[github-actions]

📦 Latest Plugin Build

Built at: 2025-05-30T19:38:07.007Z
Commit: f2f8445
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

[facebook-github-bot]

@jczhuoMeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@jczhuoMeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@jczhuoMeta merged this pull request in 17c63e4.