Skip to content

Adding Precautionary bug fix#3275

Closed
SayanPandey wants to merge 1 commit intofacebook:mainfrom
SayanPandey:PrecautionaryFixForStaticMethod
Closed

Adding Precautionary bug fix#3275
SayanPandey wants to merge 1 commit intofacebook:mainfrom
SayanPandey:PrecautionaryFixForStaticMethod

Conversation

@SayanPandey
Copy link
Copy Markdown
Contributor

@SayanPandey SayanPandey commented May 29, 2025

Description

Making some methods public static to avoid future breaks/ bugs.

Type of change

Can be considered as simple bug fix

Checklist

  • [] I have commented my code, particularly in hard-to-understand areas.
  • I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
  • [] I followed general Pull Request best practices. Meta employees to follow this wiki.
  • [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • [] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
  • [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SayanPandey SayanPandey changed the title Adding badic static Adding Precautionary bug fix May 29, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@SayanPandey merged this pull request in a84c1c3.

@tzahgr tzahgr mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants