Update product validation logic for checkout#3271
Closed
ajello-meta wants to merge 2 commits intomainfrom
Closed
Conversation
Contributor
|
@ajello-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
📦 Latest Plugin BuildBuilt at: 2025-05-29T20:00:39.115Z Download: Click here to download the plugin To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact |
Contributor
|
@ajello-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@ajello-meta merged this pull request in 062f0a8. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates product validation logic in
Checkout.php. TheWC()->cart->add_to_cart( $product_id, $quantity )function does not throw an exception when the product ID (or quantity) is invalid. It also does not throw an exception when a product fails to be added to the cart. The updated logic (1) useswc_get_product( $product_id )to retrieve the product and validate it's existence and availability and (2) verifies thatWC()->cart->add_to_cart( $product_id, $quantity )returnstrue.Type of change
Test Plan
http://test-site-i.local/fb-checkout?products=<ID>:<#>. Fill in the "ID" and/or "#" with invalid inputs.