Fix - Removed html tags from product set description.#3230
Closed
mshymon wants to merge 1 commit intofacebook:mainfrom
Closed
Fix - Removed html tags from product set description.#3230mshymon wants to merge 1 commit intofacebook:mainfrom
mshymon wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@mshymon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
5 tasks
vahidkay-meta
pushed a commit
that referenced
this pull request
May 28, 2025
Summary: Problem. The raw WC category description contains html tag (e.g. <p>). This gest synced to Meta and the string is not expected to contain the tags. Fix. Remove the tags from the raw description before it is synchronised to Meta. - Bug fix (non-breaking change which fixes an issue) - Fix - Removed html tags from product set description. Pull Request resolved: #3230 Test Plan: `./vendor/bin/phpunit --filter ProductSetSyncTest` Reviewed By: nrostrow-meta, carterbuce Differential Revision: D75236740 Pulled By: mshymon fbshipit-source-id: 73a06bf35414d2a872b6d88ce6429bc0cc31b1bc
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem. The raw WC category description contains html tag (e.g.
). This gest synced to Meta and the string is not expected to contain the tags.
Fix. Remove the tags from the raw description before it is synchronised to Meta.
Type of change
Changelog entry
Test Plan
./vendor/bin/phpunit --filter ProductSetSyncTest