Revert "Fix WC Product Bundles compatibility by using empty().trigger"#3212
Closed
vinkmeta wants to merge 1 commit into
Closed
Revert "Fix WC Product Bundles compatibility by using empty().trigger"#3212vinkmeta wants to merge 1 commit into
vinkmeta wants to merge 1 commit into
Conversation
Contributor
📦 Latest Plugin BuildBuilt at: 2025-05-19T14:49:16.962Z Download: Click here to download the plugin To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact |
1 similar comment
Contributor
📦 Latest Plugin BuildBuilt at: 2025-05-19T14:49:16.962Z Download: Click here to download the plugin To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact |
Contributor
|
@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
vinkmeta
added a commit
that referenced
this pull request
May 19, 2025
#3212) Summary: ## Description This reverts commit 32d3707 as it breaks Product Category dropdown. ### Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Revert "Fix WC Product Bundles compatibility by using empty().trigger" Pull Request resolved: #3212 Reviewed By: SayanPandey, mshymon Differential Revision: D74998559 Pulled By: vinkmeta fbshipit-source-id: dc1744ed588bca973612bbc432857261c5e04d67
This was referenced May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 32d3707 as it breaks Product Category dropdown.
Type of change
Checklist
Changelog entry
Revert "Fix WC Product Bundles compatibility by using empty().trigger"