[WAUM] Fix the product sync button showing up twice#3199
Closed
sharunaanandraj wants to merge 1 commit intomainfrom
Closed
[WAUM] Fix the product sync button showing up twice#3199sharunaanandraj wants to merge 1 commit intomainfrom
sharunaanandraj wants to merge 1 commit intomainfrom
Conversation
sharunaanandraj
commented
May 15, 2025
|
|
||
| $this->screens = $this->build_menu_item_array(); | ||
|
|
||
| add_action( 'admin_menu', array( $this, 'build_menu_item_array' ) ); |
Contributor
Author
There was a problem hiding this comment.
This is called twice, so removing
Contributor
|
@sharunaanandraj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
📦 Latest Plugin BuildBuilt at: 2025-05-15T18:19:10.894Z Download: Click here to download the plugin To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact |
1 similar comment
Contributor
📦 Latest Plugin BuildBuilt at: 2025-05-15T18:19:10.894Z Download: Click here to download the plugin To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact |
Contributor
|
@sharunaanandraj merged this pull request in 10e90e5. |
sharunaanandraj
added a commit
that referenced
this pull request
May 15, 2025
Summary: ## Description The product sync button was showing up twice due to a change we added when building the rollout switch. Fixing this in this diff. ### Type of change - Bug fix (non-breaking change which fixes an issue) ## Changelog entry Fix the product sync button showing up twice Pull Request resolved: #3199 Test Plan: ## Screenshots ### Before Change <img width="1131" alt="Screenshot 2025-05-15 at 11 16 56 AM" src="https://github.com/user-attachments/assets/40f9da5b-57aa-402d-abe1-edc3d1e19905" /> ### With GK Product sync shows once with utility messages tab <img width="961" alt="Screenshot 2025-05-15 at 11 02 41 AM" src="https://github.com/user-attachments/assets/5bf92fd0-0c22-4449-8e96-3ef351c1f6cb" /> ### Without GK Product sync shows once without utility messages tab <img width="960" alt="Screenshot 2025-05-15 at 11 11 19 AM" src="https://github.com/user-attachments/assets/21074f65-9910-4cc7-b6dd-3f182d1486f8" /> Reviewed By: jkaryo1 Differential Revision: D74827821 Privacy Context Container: L1332882 Pulled By: sharunaanandraj fbshipit-source-id: 8880c3024ada1066230ac262e9a7bac12aaaacfe
Merged
This was referenced May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The product sync button was showing up twice due to a change we added when building the rollout switch. Fixing this in this diff.
Type of change
Changelog entry
Fix the product sync button showing up twice
Test Plan
Screenshots
Before Change
With GK
Product sync shows once with utility messages tab
Without GK
Product sync shows once without utility messages tab
