[WAUM][38/n]Integrate GK RolloutSwitch for Whatsapp Utility Messaging Tab#3147
[WAUM][38/n]Integrate GK RolloutSwitch for Whatsapp Utility Messaging Tab#3147sharunaanandraj merged 8 commits intoWAUM-devfrom
Conversation
sharunaanandraj
force-pushed
the
gk-integration-1.1
branch
from
11d324d to
d2cd398
Compare
| */ | ||
| private function parse_dependencies( $args ) { | ||
| $dependencies = wp_parse_args( | ||
| $dependencies = wp_parse_args( |
There was a problem hiding this comment.
fixed by ./vendor/bin/phpcbf
| $previous_minor = $older_minor; | ||
|
|
||
| $supported_minor--; | ||
| --$supported_minor; |
There was a problem hiding this comment.
fixed by ./vendor/bin/phpcbf
There was a problem hiding this comment.
discard Plugin and Dependencies changes?
There was a problem hiding this comment.
This keeps showing up on every PR, thought it would be better to fix it instead.
sharunaanandraj
changed the title
| */ | ||
| public function __construct() { | ||
| add_action( 'init', array( $this, 'initHook' ) ); | ||
| $this->initHook(); |
There was a problem hiding this comment.
is this change required?
There was a problem hiding this comment.
Yes. Previously initHook was only executed when wordpress init action takes place, which happens before the RolloutSwitch API fetch causing an error. This would allow initHook to only be executed after RolloutSwitch fetch
| $external_business_id = $this->plugin->get_connection_handler()->get_external_business_id(); | ||
| if ( empty( $external_business_id ) ) { | ||
| $access_token = $this->plugin->get_connection_handler()->get_access_token(); | ||
| if ( empty( $access_token ) || empty( $external_business_id ) ) { |
There was a problem hiding this comment.
why do you need access_token? Where is it being used?
There was a problem hiding this comment.
It's used within get_api call for the RolloutSwitch API fetch.
|
@iodic Planning to merge this PR since it is not a major functionality change. Please let me know if you need any updates here. |
4 participants
Description
Integrate GK Switch for Whatsapp Utility Messaging Tab in both Settings and Enhanced Settings(MiCE) flows
Type of change
Changelog entry
Integrate GK Switch for Whatsapp Utility Messaging Tab
Test Plan
GK Pass
Settings
Enhanced Settings
GK Fail
Settings
Enhanced Settings