Skip to content

Removed failing test due to merge conflicts #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vinkmeta wants to merge 1 commit into from
Closed

Removed failing test due to merge conflicts #3103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions tests/Unit/fbproductTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,61 +1079,6 @@ public function test_external_update_time_unset() {
$this->assertEquals(isset($data['external_update_time']), false);
}



/**
* Tests for get_fb_short_description() method
*/
public function test_get_fb_short_description() {
// Test 1: Variation products should inherit parent's short description
$variable_product = WC_Helper_Product::create_variation_product();
$variation = wc_get_product($variable_product->get_children()[0]);

// Set the parent product's short description
$variable_product->set_short_description('parent short description');
$variable_product->save();

// Even if we try to set a short description on the variation (which we dont have functionality for in WooCommerce UI)
$variation->set_short_description('variation short description - should be ignored');
$variation->save();

$parent_fb_product = new \WC_Facebook_Product($variable_product);
$facebook_product = new \WC_Facebook_Product($variation, $parent_fb_product);
$description = $facebook_product->get_fb_short_description();

// Variations should inherit the parent product's short description
$this->assertEquals('parent short description', $description, 'Variations should inherit parent short description');

// Test 2: Gets short description from post excerpt for simple products
$product = WC_Helper_Product::create_simple_product();
$product->set_short_description('product short description');
$product->save();

$facebook_product = new \WC_Facebook_Product($product);
$description = $facebook_product->get_fb_short_description();
$this->assertEquals('product short description', $description);

// Test 3: Returns empty string when no short description exists
$product = WC_Helper_Product::create_simple_product();
$product->set_short_description('');
$product->save();

$facebook_product = new \WC_Facebook_Product($product);
$description = $facebook_product->get_fb_short_description();
$this->assertEquals('', $description);

// Test 4: Applies filters
$filter = $this->add_filter_with_safe_teardown('facebook_for_woocommerce_fb_product_short_description', function($description, $id) {
return 'filtered short description for product ' . $id;
}, 10, 2);

$description = $facebook_product->get_fb_short_description();
$this->assertEquals('filtered short description for product ' . $product->get_id(), $description);

// Remove the filter early
$filter->teardown_safely_immediately();
}

/**
* Test fallback to main description when it's less than 1000 characters.
*/
Expand Down