Skip to content

Add external ID retrieval to Event class and adjust action priorities#3065

Open
rubycalling wants to merge 1 commit intomainfrom
feature/add-external-id-to-user-data
Open

Add external ID retrieval to Event class and adjust action priorities#3065
rubycalling wants to merge 1 commit intomainfrom
feature/add-external-id-to-user-data

Conversation

@rubycalling
Copy link

Description

Introduces the addition of an external ID to user data, aligning with the best practices outlined in the Facebook Marketing API documentation.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
  • I followed general Pull Request best practices. Meta employees to follow this wiki.
  • I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
  • I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

Changelog entry

  • Added support for external ID in user data to enhance integration.

Test Plan

Ensured that the external ID is correctly appended to user data without affecting existing functionality.

Screen.Recording.2025-04-16.at.18.36.42.mov

@facebook-github-bot
Copy link
Contributor

@rubycalling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@rubycalling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@rubycalling rubycalling force-pushed the feature/add-external-id-to-user-data branch from 2fecaea to 72c2954 Compare April 28, 2025 12:28
@facebook-github-bot
Copy link
Contributor

@rubycalling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

Hi @rubycalling!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants