Skip to content

Removed concept of Product Group Deletion from the plugin#3062

Closed
vinkmeta wants to merge 5 commits intomainfrom
vink_1
Closed

Removed concept of Product Group Deletion from the plugin#3062
vinkmeta wants to merge 5 commits intomainfrom
vink_1

Conversation

@vinkmeta
Copy link
Contributor

Description

Removed concept of Product Group Deletion from the plugin

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
  • I followed general Pull Request best practices. Meta employees to follow this wiki.
  • I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
  • I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

Changelog entry

Removed concept of Product Group Deletion from the plugin

Test Plan

./vendor/bin/phpunit

@facebook-github-bot
Copy link
Contributor

@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link
Contributor

📦 Latest Plugin Build

Built at: 2025-05-11T22:52:43.896Z
Commit: 1d55a2a
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

1 similar comment
@github-actions
Copy link
Contributor

📦 Latest Plugin Build

Built at: 2025-05-11T22:52:43.896Z
Commit: 1d55a2a
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

@facebook-github-bot
Copy link
Contributor

@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link
Contributor

📦 Latest Plugin Build

Built at: 2025-05-12T07:46:21.736Z
Commit: 9e0b4ec
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

1 similar comment
@github-actions
Copy link
Contributor

📦 Latest Plugin Build

Built at: 2025-05-12T07:46:21.736Z
Commit: 9e0b4ec
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

@facebook-github-bot
Copy link
Contributor

@vinkmeta merged this pull request in e4b56e9.

vahidkay-meta pushed a commit that referenced this pull request May 28, 2025
Summary:

Removed concept of Product Group Deletion from the plugin

Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)

- [x] I have commented my code, particularly in hard-to-understand areas.
- [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
- [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
- [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)).
- [x] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
- [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
- [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)).

Removed concept of Product Group Deletion from the plugin

Pull Request resolved: #3062

Test Plan: ./vendor/bin/phpunit

Reviewed By: devbodaghe

Differential Revision: D73082810

Pulled By: vinkmeta

fbshipit-source-id: 9eab588b0d417a9b9ac72e9d4010daa08ef56f64
@vahidkay-meta vahidkay-meta mentioned this pull request May 28, 2025
@tzahgr tzahgr mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants