Skip to content

Remove UI of a checkbox that controls enablement of the new style feed generation. #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mshymon wants to merge 2 commits into from
Closed

Remove UI of a checkbox that controls enablement of the new style feed generation. #3056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8fe91c
Remove UI of the switch to enable new style feed generation.
mshymon Apr 14, 2025
e49c731
Fixed tests.
mshymon Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions includes/Admin/Settings_Screens/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,15 +467,6 @@ public function get_settings() {
'default' => 'no',
),

array(
'id' => \WC_Facebookcommerce_Integration::SETTING_ENABLE_NEW_STYLE_FEED_GENERATOR,
'title' => __( 'Experimental! Enable new style feed generation', 'facebook-for-woocommerce' ),
'type' => 'checkbox',
'desc' => __( 'Use new, memory improved, feed generation process.', 'facebook-for-woocommerce' ),
/* translators: %s URL to the documentation page. */
'desc_tip' => sprintf( __( 'This is an experimental feature in testing phase. Only enable this if you are experiencing problems with feed generation. <a href="%s" target="_blank">Learn more</a>.', 'facebook-for-woocommerce' ), 'https://woocommerce.com/document/facebook-for-woocommerce/#feed-generation' ),
'default' => 'no',
),
array( 'type' => 'sectionend' ),
);
}
Expand Down
10 changes: 0 additions & 10 deletions includes/Admin/Settings_Screens/Shops.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,16 +299,6 @@ public function get_settings() {
'default' => 'no',
),

array(
'id' => \WC_Facebookcommerce_Integration::SETTING_ENABLE_NEW_STYLE_FEED_GENERATOR,
'title' => __( '[Experimental] Use new, memory improved, feed generation process', 'facebook-for-woocommerce' ),
'type' => 'checkbox',
'desc' => __( 'Enable', 'facebook-for-woocommerce' ),
/* translators: %s URL to the documentation page. */
'desc_tip' => sprintf( __( 'This is an experimental feature in testing phase. Only enable this if you are experiencing problems with feed generation. <a href="%s" target="_blank">Learn more</a>.', 'facebook-for-woocommerce' ), 'https://woocommerce.com/document/facebook-for-woocommerce/#feed-generation' ),
'default' => 'no',
),

array( 'type' => 'sectionend' ),
);
}
Expand Down
5 changes: 0 additions & 5 deletions tests/Unit/Admin/Settings/ConnectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,5 @@ public function testGetSettings(): void {
$debug_setting = $settings[2];
$this->assertEquals('checkbox', $debug_setting['type']);
$this->assertEquals('no', $debug_setting['default']);

// Check feed generator setting
$feed_setting = $settings[3];
$this->assertEquals('checkbox', $feed_setting['type']);
$this->assertEquals('no', $feed_setting['default']);
}
}
5 changes: 0 additions & 5 deletions tests/Unit/Admin/Settings/ShopsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,5 @@ public function testGetSettings(): void {
$debug_setting = $settings[2];
$this->assertEquals('checkbox', $debug_setting['type']);
$this->assertEquals('no', $debug_setting['default']);

// Check feed generator setting
$feed_setting = $settings[3];
$this->assertEquals('checkbox', $feed_setting['type']);
$this->assertEquals('no', $feed_setting['default']);
}
}