Add undefined_attributes field to product syncing#3049
Open
carterbuce wants to merge 6 commits intofacebook:mainfrom
Open
Add undefined_attributes field to product syncing#3049carterbuce wants to merge 6 commits intofacebook:mainfrom
carterbuce wants to merge 6 commits intofacebook:mainfrom
Conversation
Contributor
|
@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
# Conflicts: # includes/fbproduct.php
Contributor
|
@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The /fb-checkout URL does not work for product variants that use the "Any Size", "Any Color", etc attribute selection. They must define the attribute. This PR sends a list of the attributes that do not have a defined value to Meta, so that we can hide those variants from Shops but still allow them to be synced over for use in Ads.
Type of change
Checklist
Changelog entry
Add undefined_attributes field to product syncing
Test Plan
Synced a product to Meta and verified the undefined_attributes field is sent
Screenshots
Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate
Before
After