Skip to content

Deprecate Facebook-specific Product Fields and Add Warning Banners#3028

Open
devbodaghe wants to merge 10 commits intofacebook:mainfrom
devbodaghe:deprecate_facebook_custom_fields_1
Open

Deprecate Facebook-specific Product Fields and Add Warning Banners#3028
devbodaghe wants to merge 10 commits intofacebook:mainfrom
devbodaghe:deprecate_facebook_custom_fields_1

Conversation

@devbodaghe
Copy link
Contributor

Deprecate Facebook-specific Fields and Add Warning Banners

Description

This PR implements the deprecation of several Facebook-specific fields in the product settings while maintaining backwards compatibility for existing products. It also adds warning banners to notify users about these changes.

Deprecated Fields

  • Facebook Description
  • Custom Image URL
  • Facebook Price

These fields will now only be visible for products that already have values set for them, ensuring a smooth transition for existing implementations.

Key Changes

  1. Warning Banner Implementation

    • Added warning banners for both regular products and variations that have deprecated fields
    • Banners clearly communicate which fields are being deprecated
    • Includes reassurance that existing ads and Meta shops won't be affected
  2. Conditional Field Display

    • Deprecated fields are now only shown if they contain existing values
    • Prevents new products from using deprecated fields while preserving existing data
  3. User Interface Improvements

    • Added dismissible notices for better user experience
    • Implemented clear messaging about the deprecation
    • Maintained existing functionality for products with legacy data

Example Warning Message

Screenshot 2025-04-08 at 21 01 51 Screenshot 2025-04-08 at 21 02 22

Testing Instructions

  1. Check products with existing Facebook-specific fields:

    • Verify warning banner appears
    • Confirm deprecated fields are visible and editable
    • Test banner dismissal functionality
  2. Create a new product:

    • Verify deprecated fields are not shown
    • Confirm other Facebook integration features work as expected
  3. Test variations:

    • Check warning banner appears for variations with existing Facebook-specific data
    • Verify deprecated fields are only shown for variations with existing values

Impact

This change provides a graceful deprecation path while:

  • Maintaining backwards compatibility
  • Preventing confusion for new implementations
  • Clearly communicating changes to users

@facebook-github-bot
Copy link
Contributor

@devbodaghe has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants