Skip to content

Make page title in enhanced settings static #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajello-meta wants to merge 1 commit into from
Closed

Make page title in enhanced settings static #2985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions includes/Admin/Enhanced_Settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,30 +141,12 @@ public function is_marketing_enabled() {
*/
private function connect_to_enhanced_admin( $screen_id ) {
if ( is_callable( 'wc_admin_connect_page' ) ) {
$crumbs = array(
__( 'Facebook for WooCommerce', 'facebook-for-woocommerce' ),
);
//phpcs:ignore WordPress.Security.NonceVerification.Recommended
if ( ! empty( $_GET['tab'] ) ) {
//phpcs:ignore WordPress.Security.NonceVerification.Recommended
switch ( $_GET['tab'] ) {
case Shops::ID:
$crumbs[] = __( 'Shops', 'facebook-for-woocommerce' );
break;
case Settings_Screens\Product_Sync::ID:
$crumbs[] = __( 'Product sync', 'facebook-for-woocommerce' );
break;
case Settings_Screens\Advertise::ID:
$crumbs[] = __( 'Advertise', 'facebook-for-woocommerce' );
break;
}
}
wc_admin_connect_page(
array(
'id' => self::PAGE_ID,
'screen_id' => $screen_id,
'path' => add_query_arg( 'page', self::PAGE_ID, 'admin.php' ),
'title' => $crumbs,
'title' => [ __( 'Facebook for WooCommerce', 'facebook-for-woocommerce' ) ],
)
);
}
Expand Down