Skip to content

Removing Variant Level Sync #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Removing Variant Level Sync #2931

wants to merge 6 commits into from

Conversation

SayanPandey
Copy link
Contributor

@SayanPandey SayanPandey commented Mar 10, 2025 •
edited
Loading

Changes proposed in this Pull Request:

  1. The Variant level sync is removed in this PR for Variable products.
  2. The Sync option now exist in Facebook tab.
  3. Selecting your choice of sync will be effective on the product and all its variants.

In general we are moving forward with Syncing at Product level than Variant level.

Screenshots:

Before After
1. At Variant level sync controls 1. At variant level sync controls removed
image image
2. At facebook tab sync controls missing 2. At facebook tab Sync controls added
image image

Detailed test instructions:

  1. Make a variant product
  2. Add some variant attributes
  3. Now make variants
  4. Try to use the sync - do not sync options in facebook tabs
  5. Observe the changes in Catalog in commerce manager

@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SayanPandey has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SayanPandey has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SayanPandey has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SayanPandey SayanPandey force-pushed the RemovingVariantLevelSync branch 2 times, most recently from 1032dc9 to b1bde06 Compare April 9, 2025 14:20
@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SayanPandey SayanPandey force-pushed the RemovingVariantLevelSync branch from 061ae4f to 9eca6fd Compare April 28, 2025 11:12
@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SayanPandey @facebook-github-bot