Updating some MBE params used by MiCE solution#2925
Merged
jczhuoMeta merged 1 commit intoMICE-4from Mar 6, 2025
Merged
Conversation
sol-loup
reviewed
Mar 6, 2025
| $connection_handler = facebook_for_woocommerce()->get_connection_handler(); | ||
| $external_client_metadata = array( | ||
| 'shop_domain' => wc_get_page_permalink( 'shop' ) ? wc_get_page_permalink( 'shop' ) : \home_url(), | ||
| 'shop_domain' => wc_get_page_permalink( 'shop' ), |
Contributor
There was a problem hiding this comment.
Curious -- do you think we can discard the fallback?
Contributor
Author
There was a problem hiding this comment.
wc_get_page_permalink
https://hooks.wbcomdesigns.com/reference/functions/wc_get_page_permalink/
This one already contains the fallback. Remove to keep the code cleaner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a. Default Business name -> something meaningful
b. Timezone to non-fixed timezone
c. Update the client token to actually Woo's token. It was using Magento's token
d. Adding platform_store_id
Testing:
Manual test:

Resulting URL: