Skip to content

phpcs hotfix #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sol-loup wants to merge 2 commits into from
Closed

phpcs hotfix #2921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6a92b5
Reverting a lint fix which defined dynamic variables
sol-loup Mar 5, 2025
f32c5d1
adding lint ignore logic
sol-loup Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions includes/Framework/Utilities/AsyncRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,6 @@ abstract class AsyncRequest {
/** @var array request data */
protected $data = [];

/** @var array query arguments */
protected $query_args;

/** @var string query URL */
protected $query_url;

/** @var array request arguments */
protected $request_args;


/**
* Initiate a new async request
*
Expand Down Expand Up @@ -97,6 +87,8 @@ protected function get_query_args() {

// Check if a child class has defined this property for custom query args
if ( property_exists( $this, 'query_args' ) ) {
// Dynamic property; not defined in the parent class, and not a true lint error
// phpcs:ignore
return $this->query_args;
}

Expand All @@ -117,6 +109,8 @@ protected function get_query_url() {

// Check if a child class has defined this property for a custom URL
if ( property_exists( $this, 'query_url' ) ) {
// Dynamic property; not defined in the parent class, and not a true lint error
// phpcs:ignore
return $this->query_url;
}

Expand All @@ -136,6 +130,8 @@ protected function get_request_args() {

// Check if a child class has defined this property for custom request args
if ( property_exists( $this, 'request_args' ) ) {
// Dynamic property; not defined in the parent class, and not a true lint error
// phpcs:ignore
return $this->request_args;
}

Expand Down