[WIP] Update node/NPM packages #2912
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "use_gh_release_notes": true | ||
| }, | ||
| "engines": { | ||
| "node": ">=12.22 <=16", |
Contributor
There was a problem hiding this comment.
Don't we need to set specific versions of npm/node that we want to test this on?
Collaborator
Author
There was a problem hiding this comment.
You are right; I have set them to a minimum of the latest node LTS & matching npm version.
iodic
force-pushed
the
chore/update-node-packages
branch
2 times, most recently
from
14e30c8 to
c97914e
Compare
Contributor
|
@iodic What is the plan for this PR ? Can we merge this by next week ? |
iodic
force-pushed
the
chore/update-node-packages
branch
from
c97914e to
f98e0b7
Compare
iodic
force-pushed
the
chore/update-node-packages
branch
from
f98e0b7 to
6e249cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This changeset includes the following changes:
@wordpresspackages).Detailed test instructions:
As this affects the build process, we need to do end to end testing to ensure these updates do not introduce regressions.