Create tests for ProductFeedUploads create endpoint#2902
Closed
ajello-meta wants to merge 2 commits intomainfrom
Closed
Create tests for ProductFeedUploads create endpoint#2902ajello-meta wants to merge 2 commits intomainfrom
ajello-meta wants to merge 2 commits intomainfrom
Conversation
Contributor
|
@ajello-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@ajello-meta has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@ajello-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@ajello-meta merged this pull request in a064a1a. |
This was referenced Mar 5, 2025
Closed
tzahgr
pushed a commit
that referenced
this pull request
Mar 24, 2025
Summary: ### Changes proposed in this Pull Request: This PR introduces unit tests for the `Request` and `Response` classes in the `WooCommerce\Facebook\API\ProductCatalog\ProductFeedUploads\Create` namespace. These tests ensure that the classes behave as expected when handling API requests and responses for creating product feed uploads. ### Detailed test instructions: 1. Run the unit tests using the WordPress testing framework to ensure they pass successfully. 2. Verify that the `Request` test checks the HTTP method, path, and data properties. 3. Verify that the `Response` test checks the `id` and `data` properties for correct parsing. Pull Request resolved: #2902 Test Plan: Imported from GitHub, without a `Test Plan:` line. **!---- (auto-generated) DO NOT EDIT OR PUT ANYTHING AFTER THIS LINE ----!** MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: bloks / Diff Version V2 https://internalfb.com/intern/testinfra/testrun/12666374022148420 MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: www / Diff Version V2 https://internalfb.com/intern/testinfra/testrun/8162774577600955 Reviewed By: carterbuce, nrostrow-meta Differential Revision: D70210484 Pulled By: ajello-meta fbshipit-source-id: 0e9a162726a18083aae7c12a2edf568756a69d40
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR introduces unit tests for the
RequestandResponseclasses in theWooCommerce\Facebook\API\ProductCatalog\ProductFeedUploads\Createnamespace. These tests ensure that the classes behave as expected when handling API requests and responses for creating product feed uploads.Detailed test instructions:
Requesttest checks the HTTP method, path, and data properties.Responsetest checks theidanddataproperties for correct parsing.