Closed
Conversation
github-actions
bot
added
changelog: fix
Contributor
|
Hey, Changes looks good! Can you please update the PR Summary highlighting the changes in behaviour before and after this PR. |
Contributor
|
This looks like it moves some stuff around |
iodic
changed the title
_load_textdomain_just_in_time noticeinit hook
Collaborator
Author
|
I have updated the PR description and the code style in the changeset was updated. |
vahidkay-meta
approved these changes
Feb 5, 2025
iodic
force-pushed
the
fix/translations_loaded_too_early
branch
from
945d406 to
80ad6b8
Compare
vahidkay-meta
approved these changes
Feb 12, 2025
Contributor
|
@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@vahidkay-meta merged this pull request in 351a8e3. |
iodic
added a commit
that referenced
this pull request
Feb 18, 2025
Summary: ### Changes proposed in this Pull Request: The plugin's admin page properties contained strings being translated and these were called before the `init` hook causing the following notice to be logged: ``` Notice: Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the facebook-for-woocommerce domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the init action or later. Please see Debugging in WordPress for more information. (This message was added in version 6.7.0.) in /home/public_html/wp-includes/functions.php on line 6114 ``` This changeset moves the admin pages' properties into the `init` hook so we follow the proper way of handling translations. More information about the issue: https://make.wordpress.org/core/2024/10/21/i18n-improvements-6-7/#Enhanced-support-for-only-using-PHP-translation-files. ### Screenshots:  ### Detailed test instructions: To recreate the issue, please follow these steps: 1. Enable `WP_DEBUG` and either show the errors on page or in the debug log. 2. Switch the site to a different language, e.g. French. 3. You should see the notice at the top of the admin page (like in the screenshot above) or in the debug log. Pull Request resolved: #2866 Reviewed By: akpurifb Differential Revision: D69531576 Pulled By: vahidkay-meta fbshipit-source-id: 08e497ceb404d0fd7c284aad7d4cfc235ff5b41b
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
Summary: ## Changelog: * Add - FB product video field to add videos. Also added products sync to support the video field with Batch API by gurtejrehal in #2874 * Tweak - tests for #2874 by gurtejrehal in #2888 * Tweak - tests for Product Update action as ramp up task by nealweiMeta in #2883 * Fix - translations loading before the init hook by iodic in #2866 * Fix - Fixed feeds by requesting a feed file upload session after feed file is generated and added missing new fields to the feed file by mshymon in #2841 Pull Request resolved: #2891 Reviewed By: akpurifb Differential Revision: D69836863 Pulled By: vahidkay-meta fbshipit-source-id: 32408ab4b42f60f921bd599ed982933017185b5e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
The plugin's admin page properties contained strings being translated and these were called before the
inithook causing the following notice to be logged:This changeset moves the admin pages' properties into the
inithook so we follow the proper way of handling translations.More information about the issue: https://make.wordpress.org/core/2024/10/21/i18n-improvements-6-7/#Enhanced-support-for-only-using-PHP-translation-files.
Screenshots:
Detailed test instructions:
To recreate the issue, please follow these steps:
WP_DEBUGand either show the errors on page or in the debug log.