Merged
Conversation
layoutd
approved these changes
Nov 25, 2022
Contributor
layoutd
left a comment
There was a problem hiding this comment.
Works as indicated in testing. Looks good! ![]()
❔ Confirming the PHPCS config changes included in the PR are intentional.
❔ Confirming Closes #2340 is correct in the description, as 2340 is a PR an not an issue.
Contributor
Author
|
Thank you @layoutd for the review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2299.
This PR is the same as #2340. The
Notesfolder and the corresponding addition of theSettingsMovednote were removed during a merge. This PR restores the removed code.phpcschecks? Please removephpcs:ignorecomments in changed files and fix any issues, or delete if not practical.Screenshots:
Detailed test instructions:
npm run buildAdditional details:
The Facebook menu was moved under the Marketing menu in the WP admin panel in v2.2.0. This note should be displayed only to users updating the plugin from before v2.2.0.
The Lifecycle handler stores events such as installation and upgrade. It does not record downgrades. It also stores the latest version in the options table using this key:
wc_facebook_for_woocommerce_version. This key is not updated on downgrades. Hence, it does not record events such as upgrades if we do them after installing a recent version.For example, if we install v2.6.28 and then downgrade to v2.1.4, and then upgrade to v2.6.27, the last upgrade will not be recorded. Hence for testing, we need to use 2 separate installations.
Changelog entry