Skip to content

Adds backward compatibility for WC 6.1, 6.2, 6.3. (#2362)#2363

Merged
ibndawood merged 2 commits intodevelopfrom
fix/implement-abstract-method
Nov 9, 2022
Merged

Adds backward compatibility for WC 6.1, 6.2, 6.3. (#2362)#2363
ibndawood merged 2 commits intodevelopfrom
fix/implement-abstract-method

Conversation

@ibndawood
Copy link
Copy Markdown
Contributor

@ibndawood ibndawood commented Nov 8, 2022

Changes proposed in this Pull Request:

Closes #2362 .

This PR implements the get_parent_id method in the Setup Task class as it is declared as abstract in WooCommerce versions mentioned.

  • Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Detailed test instructions:

  1. Install and activate WooCommerce 6.2.
  2. Install this PR and verify the task Setup Facebook for WooCommerce is displayed properly in WooCommerce > Home.
  3. Update WooCommerce to version 7.1
  4. Verify the task Setup Facebook for WooCommerce is displayed properly in WooCommerce > Home.

Additional details:

Changelog entry

Fix - Add backward compatibility for WC 6.1, 6.2, and 6.3 versions.

@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Nov 8, 2022
@ibndawood ibndawood requested a review from a team November 8, 2022 17:27
@ibndawood ibndawood merged commit 4222e2c into develop Nov 9, 2022
@ibndawood ibndawood deleted the fix/implement-abstract-method branch November 9, 2022 04:13
This was referenced Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backward compatibility for WooCommerce 6.1, 6.2 and 6.3

2 participants