Skip to content

Redirect the users to advertise tab of the plugin when FBE is installed#2356

Merged
rawdreeg merged 3 commits intodevelopfrom
change/redirect-fbe-to-advertise-tab
Nov 7, 2022
Merged

Redirect the users to advertise tab of the plugin when FBE is installed#2356
rawdreeg merged 3 commits intodevelopfrom
change/redirect-fbe-to-advertise-tab

Conversation

@rahulmaddineni
Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

When FBE is successfully installed, instead of redirecting the user to settings tab redirect them to the advertise tab.

Screenshots:

Tested with Local App running WooCommerce 7

Screen.Recording.2022-11-04.at.11.27.58.AM.mov

Changelog entry

Update - On successful FBE install users will be redirected to Advertise tab of the plugin

@rahulmaddineni rahulmaddineni added feature: onboarding Related to onboarding, set up and initial connection to Facebook. changelog: update Big changes to something that wasn't broken. labels Nov 4, 2022
@rahulmaddineni rahulmaddineni self-assigned this Nov 4, 2022
@rawdreeg rawdreeg requested a review from a team November 5, 2022 18:04
@budzanowski
Copy link
Copy Markdown
Contributor

@rahulmaddineni,
We have reviewed the code. @rawdreeg has made one small addition. If the connection procedure fails we still want to redirect to settings. Going to Ads makes no sense when there is no connection. We have let ourselves to do the commits to speed things up a bit. I hope that this is OK with you!

@rawdreeg rawdreeg merged commit fa334cf into develop Nov 7, 2022
@rawdreeg rawdreeg deleted the change/redirect-fbe-to-advertise-tab branch November 7, 2022 12:02
@rahulmaddineni
Copy link
Copy Markdown
Contributor Author

@rahulmaddineni, We have reviewed the code. @rawdreeg has made one small addition. If the connection procedure fails we still want to redirect to settings. Going to Ads makes no sense when there is no connection. We have let ourselves to do the commits to speed things up a bit. I hope that this is OK with you!

Hi @budzanowski & @rawdreeg good catch on the exception. Thanks for making the change & merging it.

@ibndawood ibndawood mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: update Big changes to something that wasn't broken. feature: onboarding Related to onboarding, set up and initial connection to Facebook.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants