Replace an Internal namespace class method used in HPOS compatibility#2350
Merged
Replace an Internal namespace class method used in HPOS compatibility#2350
Conversation
…ass namesspace The Internal namespace class CustomOrdersTableController should not be used. The method custom_orders_table_usage_is_enabled is replaced by a static method from OrderUtil public class which mirrors the Internal class method
github-actions
bot
added
changelog: fix
JPry
reviewed
Nov 1, 2022
Contributor
JPry
left a comment
JPry
left a comment
There was a problem hiding this comment.
Looks good, though I've added a few suggestions.
Thank you. Co-authored-by: Jeremy Pry <JPry@users.noreply.github.com>
rawdreeg
approved these changes
Nov 7, 2022
Contributor
rawdreeg
left a comment
rawdreeg
left a comment
There was a problem hiding this comment.
Looks Good. Thanks, @ibndawood!
Contributor
Author
|
Thank you @rawdreeg 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2347
The Internal namespace class
CustomOrdersTableControllershould not be used. The methodcustom_orders_table_usage_is_enabledis replaced by a static method fromOrderUtilpublic class which mirrors the Internal class methodphpcschecks? Please removephpcs:ignorecomments in changed files and fix any issues, or delete if not practical.Detailed test instructions:
Use the WooCommerce orders tables.facebook-for-woocommerce-modal,wc-facebook-google-product-category-fieldsandtmpl-facebook-for-woocommerce-modalare enqueued.Use the WordPress posts table.facebook-for-woocommerce-modal,wc-facebook-google-product-category-fieldsandtmpl-facebook-for-woocommerce-modalare enqueued.Additional details:
This PR simply corrects the class used in #2345
Changelog entry