feat: add dimension kelvin #692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessai
reviewed
May 19, 2022
| @@ -52,6 +53,13 @@ allExamples = concat | |||
| , "2 degrees below zero" | |||
| , "2 below zero" | |||
| ] | |||
| , examples (simple Kelvin 44) | |||
There was a problem hiding this comment.
these examples look good, classifiers need to be regenerated
There was a problem hiding this comment.
I've run
stack build :duckling-regen-exe && stack exec duckling-regen-exe && stack test
And I can parse out kelvins.
curl -XPOST http://0.0.0.0:8000/parse --data 'locale=en_GB&text=44 kelvin'
[{"body":"44 kelvin","start":0,"value":{"value":44,"type":"value","unit":"kelvin"},"end":9,"dim":"temperature","latent":false}]
curl -XPOST http://0.0.0.0:8000/parse --data 'locale=en_GB&text=11 kelvins'
[{"body":"11 kelvins","start":0,"value":{"value":11,"type":"value","unit":"kelvin"},"end":10,"dim":"temperature","latent":false}]
The only classifier that updated was IT_XX.hs 🤷🏽 I was expecting EN_XX.hs to update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the dimension kelvin to temperature rules. Its a SI (International System of Units) base unit, so eventually it could be included in all languages.
Typically it's expressed without the degree key word. Also its lowercase except when expressed as a single character
K. You wouldn't say 44 degrees Kelvin rather 44 kelvins