Enhancement + Fixes for Hebrew Language - Duration+TimeGrain+Time+Amount #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt ("idanadut" fork commit)
Handled preposition, hebrew plural forms, grammer miseaks and added support for new cases that are different from the "english language format" that some of the rules had to the correct Hebrew form.
Mostly these enhancement are about new hebrew grammer options to write time intervals, catch simple times correcly, and handle more complex forms.
All changes were tested carefully and extensively to verify all cases (and some tests added to corpus) -> examples:
Phrases such as "ב15 לחודש" (which mean "on the 15th of this month"), "שנה שעברה" (which means "last year"), "לפני שלושה חודשים" (which means "three months ago"), "חצי שנה אחרונה" ("past half a year"), "בין 15 לנובמבר לבין 18 לדצמבר" ("between 15th of November to 18th of December") - will now work correctly!
|
What does it mean that the Travis CI build failed("The command "cabal check" exited with 1.")? |
|
The travis build has a simple fix (361cf01) but it seems PR are not being reviewed/merged in this project anymore. (Edit: the commit is now merged) |
|
@idanadut can this be split into separate PRs? one per dimension? |
|
@chessai Yes, sure. I'm not sure I'll be able to get to it any time soon , so you are welcome to do so if you'd like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
("idanadut" fork commit)
Handled preposition, hebrew plural forms, grammer miseaks and added support for new cases that are different from the "english language format" that some of the rules had to the correct Hebrew form.
Mostly these enhancement are about new hebrew grammer options to write time intervals, catch simple times correcly, and handle more complex forms.
All changes were tested carefully and extensively to verify all cases (and some tests added to corpus) -> examples:
Phrases such as "ב15 לחודש" (which mean "on the 15th of this month"), "שנה שעברה" (which means "last year"), "לפני שלושה חודשים" (which means "three months ago"), "חצי שנה אחרונה" ("past half a year"), "בין 15 לנובמבר לבין 18 לדצמבר" ("between 15th of November to 18th of December") - will now work correctly!