-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support early/mid/late <month> #35
Comments
Hi @pcgreat, do you think you can implement this? Thanks! |
@patapizza I will try my best |
@pcgreat I have the same requirement. Did you make any progress in it? Or I can try picking this up too. |
@Abhiroop I am still reading the source code, and haven't made any real progress yet. You are more than welcome to pick it up |
@serefayar thanks for your implementation! I did try your commits and it's a good reference for me to learn. However, I notice something weird and not sure if that's something you can fix: "late July" points to the July of 2018. Ideally, "late July" can be July of 2017, and "late February" to be Feb of 2018 (future by default) |
Summary: Closes #43 Reviewed By: blandinw Differential Revision: D5264974 Pulled By: patapizza fbshipit-source-id: 0330f2b
thanks @serefayar Looks perfect! |
e.g.
early June -> 06/01-06/10
mid June -> 06/11-06/20
late June -> 06/21-06/30
The text was updated successfully, but these errors were encountered: