Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(website): organise blog posts by year #9965

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

GingerGeek
Copy link
Contributor

@GingerGeek GingerGeek commented Mar 20, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The blogs folder has grown over time and it would be useful to organise it by year.

Test Plan

Test links

Deploy preview: https://deploy-preview-9965--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @GingerGeek!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@GingerGeek GingerGeek changed the title Blog flatten folder feat(content-blog) Introduce flattenFolders Mar 20, 2024
Copy link

netlify bot commented Mar 20, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 53490ad
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65fb0f1182ca250008d586ea
😎 Deploy Preview https://deploy-preview-9965--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 20, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 60 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 53 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 71 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 20, 2024
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super fan of this new option, and wonder if we really need it?

What prevents you from adopting this FS structure?

CleanShot 2024-03-20 at 17 07 45

According to what I see, it works out of the box, see sandbox:
https://stackblitz.com/edit/github-8ukygb

We support multiple date extraction patterns allowing you to group by year, month and/or day:

https://docusaurus.io/docs/next/blog#blog-post-date

CleanShot 2024-03-20 at 17 14 17 2


However I agree that we should group our blog posts by year so if you want to keep your website blog post refactor in this PR, I'm open to merge it without introducing the new option.

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Mar 20, 2024
@GingerGeek GingerGeek changed the title feat(content-blog) Introduce flattenFolders refactor(website): organise blog posts by year Mar 20, 2024
@GingerGeek
Copy link
Contributor Author

Yeap agreed with your comments here, clearly I should read docs better!

I have kept the refactor for blog locations and removed the new option

Copy link

argos-ci bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Mar 20, 2024, 5:05 PM

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 20, 2024
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants