-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): throw error when official docusaurus dependencies use different versions #9381
feat(core): throw error when official docusaurus dependencies use different versions #9381
Conversation
…ugin versions additionally remove import for logger because it is not needed.
Please, check for existing PRs before sending one. #9380 |
Sorry, I see you actually claimed the issue first! |
Could you respect the PR template? Most importantly it asks you to link to the issue to intend to address because it will be automatically closed if you include text like "closes #xxxx". |
@Josh-Cena Thanks for noticing haha. But if you think the other PR is better in some way, you can merge that one. Also I was using Gitpod to make this PR, and I think there should've been some extra info in the PR description that I should've added like a checklist. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
@Josh-Cena The tests seem to have failed, but I'm not sure why. Could you take a look and explain why they're not passing? |
The test logs are public and you can click on them. For example: https://github.com/facebook/docusaurus/actions/runs/6445635746/job/17499918105#step:5:1 The reason is because we have a test that expects mismatching plugins to log a message but run completely nontheless, while it now throws an error. You may take inspiration from the other PR to modify the test. |
@Josh-Cena Thanks for explaining! I updated the test |
Thanks 👍 |
Pre-flight checklist
Motivation
Test Plan
Related issues/PRs
#9342