Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Netlify branch deploys should only deploy default locale "en" #7788

Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 15, 2022

chore: Netlify branch deploys should only deploy default locale "en"

Follow-up of #7787

We don't want branch deploys like docusaurus-v2 to be slow and do anything with Crowdin

Users reading v2 doc will read it from the prod website deployment (always deployed from main branch)

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Jul 15, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 15, 2022
@slorber slorber changed the base branch from main to docusaurus-v2 July 15, 2022 10:25
@@ -23,7 +23,8 @@
"build:blogOnly": "cross-env yarn build --config=docusaurus.config-blog-only.js",
"build:fast": "cross-env BUILD_FAST=true yarn build --locale en",
"netlify:build:production": "yarn docusaurus write-translations && yarn netlify:crowdin:delay && yarn netlify:crowdin:uploadSources && yarn netlify:crowdin:downloadTranslations && yarn build && yarn test:css-order",
"netlify:build:deployPreview": "yarn docusaurus write-translations --locale fr --messagePrefix '(fr) ' && yarn build && yarn test:css-order",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed because we used to deploy "fr" in deploy previews, but not anymore

@netlify
Copy link

netlify bot commented Jul 15, 2022

[V2]

Name Link
🔨 Latest commit 1990d7b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62d140ab99949f0008172356
😎 Deploy Preview https://deploy-preview-7788--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 77 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 81 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.8 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 608 kB
website/build/index.html 38.9 kB

compressed-size-action

@slorber slorber merged commit 2ef40c2 into docusaurus-v2 Jul 15, 2022
@slorber slorber deleted the slorber/v2/netlify-deploy-branches-no-translations branch July 15, 2022 10:45
This was referenced May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants