Conversation
slorber
added
the
pr: ignore
slorber
commented
Jun 2, 2022
| - jest.config.mjs | ||
| - packages/** | ||
| - tsconfig.json | ||
| - .github/workflows/tests-e2e.yml |
Collaborator
Author
There was a problem hiding this comment.
@Josh-Cena is this one really needed? Afaik this is the default behavior
Collaborator
There was a problem hiding this comment.
Ah... really? We can remove it then. I just added it last time when I modified E2E tests to be sure it gets triggered.
Collaborator
Author
There was a problem hiding this comment.
yeah... you might be right as removing the line did not trigger the e2e CI 🤪
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI not triggering when it should
See also #7549 (comment)