Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update gtag docs to reflect what a GA4 tag looks like #7252

Merged
merged 1 commit into from
Apr 28, 2022
Merged

docs: update gtag docs to reflect what a GA4 tag looks like #7252

merged 1 commit into from
Apr 28, 2022

Conversation

johnnyreilly
Copy link
Contributor

@johnnyreilly johnnyreilly commented Apr 27, 2022

Motivation

This PR is a follow on from #6184 which I mean to improve the docs for GA4 but actually didn't. This was discussed in #7221

The change made in this PR reflects the format required for GA4 properties which I'm successfully using here: https://github.com/johnnyreilly/blog.johnnyreilly.com/blob/4e824dc2172efca72c075f1dbc3a39a92fd22064/blog-website/docusaurus.config.js#L35

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No test - it's docs

Related PRs

See above

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 27, 2022
@johnnyreilly johnnyreilly mentioned this pull request Apr 27, 2022
2 tasks
@netlify
Copy link

netlify bot commented Apr 27, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit b59616c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62696e86ffe82a0008d1dc88
😎 Deploy Preview https://deploy-preview-7252--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 57
🟢 Accessibility 100
🟠 Best practices 83
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7252--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title Update plugin-google-gtag documentation to reflect what a GA4 tag looks like docs: update gtag docs to reflect what a GA4 tag looks like Apr 28, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@Josh-Cena Josh-Cena merged commit b747143 into facebook:main Apr 28, 2022
@johnnyreilly johnnyreilly deleted the patch-2 branch April 28, 2022 04:18
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants